<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <br>
    <div class="moz-cite-prefix">On 02/27/2018 03:32 AM, Michael
      Stapelberg wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CANnVG6kEOo1tJrLnEe+y-dZg_=c4SVsDgwq8Hf9tpW=YQ4=FeQ@mail.gmail.com">
      <div dir="ltr"><span></span><br>
        <span></span>
        <div bgcolor="#FFFFFF"> There's a `docs/.gitignore`, it's in a
          subdirectory. Files-Excluded will remove it from the orig
          tarball, right ? Is it really suitable here ?<br>
        </div>
        <div class="gmail_extra">
          <div class="gmail_quote">
            <div><br>
            </div>
            <div>Correct, and up to you (see the caveat which tincho
              expressed). Bug #812721 discusses a gbp import-ref command
              which would honor Files-Excluded, but we’re not quite
              there yet. So, if you want to stick to orig tarballs for
              the time being, Files-Excluded will work.</div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    In the end I solved it a better way, simply by being more selective
    in debian/docs.<br>
    <br>
    <blockquote type="cite"
cite="mid:CANnVG6kEOo1tJrLnEe+y-dZg_=c4SVsDgwq8Hf9tpW=YQ4=FeQ@mail.gmail.com">
      <div dir="ltr">
        <div class="gmail_extra">
          <div class="gmail_quote">
            <div> </div>
            <blockquote class="gmail_quote" style="margin:0px 0px 0px
              0.8ex;border-left:1px solid
              rgb(204,204,204);padding-left:1ex">
              <div bgcolor="#FFFFFF"> <br>
                For the moment the only package in which I exclude a
                file from installation is done this way:<br>
                <br>
                override_dh_auto_install:<br>
                    dh_auto_install<br>
                    find $(CURDIR)/debian -name '.tool' -type d -prune
                -exec rm -r '{}' +<br>
              </div>
            </blockquote>
            <div><br>
            </div>
            <div>nit: use find’s -delete action?</div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    Nope :) `-delete` only works for files, not directories.<br>
    <br>
    My concern here is not so much about the find command, but it's more
    the location where I look for files. Here I use $(CURDIR)/debian,
    and it works, but I'm surprised that there is not a "BUILDDIR"
    variable defined, or something similar. I'm not sure if using
    $(CURDIR)/debian works for every package in every situation, I don't
    know enough about the internals.<br>
    <br>
    <blockquote type="cite"
cite="mid:CANnVG6kEOo1tJrLnEe+y-dZg_=c4SVsDgwq8Hf9tpW=YQ4=FeQ@mail.gmail.com">
      <div dir="ltr">
        <div class="gmail_extra">
          <div class="gmail_quote">
            <div><br>
            </div>
            <div>Ah, I see what’s wrong here: you are supposed to run
              lintian on a .changes file, so that it can inspect both
              the binary packages (*.deb) and the source package
              (*.dsc). Indeed, when building gogoprotobuf and running
              “lintian golang-gogoprotobuf_0.5-1_amd64.changes”, I don’t
              get any warnings about statically linked binaries.</div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    Ahhhh indeed, thanks for pointing that.<br>
    <br>
    <blockquote type="cite"
cite="mid:CANnVG6kEOo1tJrLnEe+y-dZg_=c4SVsDgwq8Hf9tpW=YQ4=FeQ@mail.gmail.com">
      <div dir="ltr">
        <div class="gmail_extra">
          <div class="gmail_quote"><span></span><br>
            <span></span>
            <blockquote class="gmail_quote" style="margin:0px 0px 0px
              0.8ex;border-left:1px solid
              rgb(204,204,204);padding-left:1ex">
              <div bgcolor="#FFFFFF"><span> <br>
                  <blockquote type="cite">
                    <div dir="ltr">
                      <div class="gmail_extra">
                        <div class="gmail_quote">
                          <div> </div>
                          <blockquote class="gmail_quote"
                            style="margin:0px 0px 0px
                            0.8ex;border-left:1px solid
                            rgb(204,204,204);padding-left:1ex"> <br>
                            In the `-dev` packages, is
                            `${shlibs:Depends}` needed ? During the
                            builds<br>
                            I see `unknown substitution variable
                            ${shlibs:Depends}` passing by.<br>
                          </blockquote>
                          <div><br>
                          </div>
                          <div>The messages implies it’s not required.
                            I’m not entirely sure, but would suggest
                            removing it for now.</div>
                        </div>
                      </div>
                    </div>
                  </blockquote>
                  <br>
                </span> Ok. I think it should be also changed in
                dh-make-golang, should I look there and issue a PR, or
                do you prefer not to touch it for now ?</div>
            </blockquote>
            <div><br>
            </div>
            <div>Please feel free to send a PR! :)</div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
    Done !<br>
    <br>
    Thanks again for all the explanations, that helps a lot.<br>
    <br>
      Arnaud<br>
  </body>
</html>