<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 28, 2018 at 3:49 AM, Arnaud <span dir="ltr"><<a href="mailto:arnaud.rebillout@collabora.com" target="_blank">arnaud.rebillout@collabora.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-"><br>
<br>
On 02/27/2018 03:32 AM, Michael Stapelberg wrote:<br>
</span><span class="gmail-">> Once you feel your packages are ready for review (possibly this reply<br>
> prompts some changes?), please send an up-to-date list of git URLs to<br>
> what you’d like reviewed. Thanks!<br>
<br>
</span>Ok, here is the package list again, I prefer to leave all the packages<br>
on my personal salsa space for now, just so that I can fix every details<br>
according to your feedback, then cleanup the git history, and then move<br>
that definitive version to alioth or salsa, where applicable.<br>
<br>
URLS are the same as the initial email, it's just a copy/paste of the<br>
initial email, from which I removed comments that are not applicable<br>
anymore.<br>
<br>
<br>
<br>
BUMPED PACKAGES<br>
---------------<br>
<br>
#### containerd<br>
<<a href="https://salsa.debian.org/elboulangero-guest/containerd" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/containerd</a>><br>
<span class="gmail-">- As for testing the thing really, I didn't go far yet, I just launched<br>
  the binary, the log messages that appeared looked healthy enough,<br>
  and that's all for now.<br></span></blockquote><div><br></div><div>Some of the comments below apply (unnecessary-team-upload, DEP-3 headers for patches).</div><div><br></div><div>Also, this requires golang-github-containerd-console-dev to build, which is not in the archive and not in this list of packages?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
<br>
#### golang-github-docker-go-events<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-events" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-docker-go-events</a>><br></span></blockquote><div><br></div><div>Can you address these please?</div><div><div>P: golang-github-docker-go-events source: file-contains-trailing-whitespace debian/control (line 25)</div><div>I: golang-github-docker-go-events source: vcs-field-uses-insecure-uri vcs-git git://<a href="http://anonscm.debian.org/pkg-go/packages/golang-github-docker-go-events.git">anonscm.debian.org/pkg-go/packages/golang-github-docker-go-events.git</a></div><div>W: golang-github-docker-go-events source: unnecessary-team-upload</div></div><div><br></div><div>Aside from that, it looks good.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
<br>
#### golang-github-docker-go-<wbr>metrics<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-metrics" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-docker-go-metrics</a>><br></span></blockquote><div><br></div><div>Can’t build this until golang-github-prometheus-client-golang is fixed. Some of the lintian warnings above seem to apply here, too, though.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
<br>
#### golang-github-opencontainers-<wbr>image-spec<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-opencontainers-image-<wbr>spec</a>><br>
- I noticed only after doing all the work that Michael Stapelberg was<br>
  working on this package lately. I hope I don't duplicate the work.<br>
</span>- I'm not sure about the gbp.conf commit, please confirm whether<br>
  it's ok.<br></blockquote><div><br></div><div>The gbp.conf change is okay. We should eventually clean up gbp.conf across our packages, but we have enough going on for now.</div><div><br></div><div>The package looks good.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="gmail-"><br>
#### golang-github-prometheus-<wbr>client-golang<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-prometheus-client-<wbr>golang</a>><br></span></blockquote><div><br></div><div>This package cannot be cloned with gbp as-is:</div><div><div><br></div><div>% gbp clone <a href="https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang">https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang</a></div><div>gbp:info: Cloning from '<a href="https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang">https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang</a>'</div><div>gbp:error: Git command failed: Error running git checkout: error: pathspec 'master' did not match any file(s) known to git.</div></div><div><br></div><div>I think you’ll need to set debian-branch in debian/gbp.conf.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
<br>
<br>
<br>
NEW PACKAGES<br>
------------<br>
<br>
</span><span class="gmail-">#### continuity<br>
<<a href="https://salsa.debian.org/elboulangero-guest/continuity" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/continuity</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890983" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-<wbr>bin/bugreport.cgi?bug=890983</a>><br>
</span><span class="gmail-">- I ran the series of test described at<br>
  <<a href="https://github.com/containerd/continuity" rel="noreferrer" target="_blank">https://github.com/<wbr>containerd/continuity</a>>,<br>
  everything went fine.<br></span></blockquote><div><br></div><div>It would be good to add a manpage for the continuity binary. Otherwise, the package looks fine.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
<br>
#### golang-gogottrpc<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-gogottrpc" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>gogottrpc</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890958" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-<wbr>bin/bugreport.cgi?bug=890958</a>><br>
</span><span class="gmail-">- Patch and issues submitted upstream.<br></span></blockquote><div><br></div><div>Can you add DEP-3 tags to the patches please? See <a href="http://dep.debian.net/deps/dep3/">http://dep.debian.net/deps/dep3/</a>. No need to go overboard, just the last-updated/author/description/forwarded ones.</div><div><br></div><div>Also, there seems to be a lintian false-positive: it reports statically-linked-binary despite the Build-Depends on golang-go. Can you file a lintian bug about that please?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
<br>
</span><span class="gmail-">#### golang-github-containerd-btrfs<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-containerd-btrfs</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890989" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-<wbr>bin/bugreport.cgi?bug=890989</a>><br>
</span>- I disabled the test to avoid installing a btrfs-test binary. I don't<br>
  think it makes sense to create an additional binary package<br>
  just for shipping this test.<br></blockquote><div><br></div><div>Sounds good. Maybe change cmd to cmd/btrfs-test so that we’ll notice newly introduced binaries upon updates? Otherwise, the package looks good.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="gmail-"><br>
#### golang-github-containerd-<wbr>typeurl<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-containerd-typeurl</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891181" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-<wbr>bin/bugreport.cgi?bug=891181</a>><br>
- Patch submitted upstream<br></span></blockquote><div><br></div><div>Please add DEP-3 tags to the patch. Looks good otherwise.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
<br>
#### golang-github-dmcgowan-go-tar<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-dmcgowan-go-tar</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890960" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-<wbr>bin/bugreport.cgi?bug=890960</a>><br>
- This one was a tricky one, please read the commit messages for details.<br></span></blockquote><div><br></div><div>Does the package which needs this require support for sparse tar files? If not, I think we can do away with this package in favor of patching the consumer to use archive/tar instead. Doing a diff -ur shows that this package is identical to archive/tar as of Go 1.10, except for the sparse support, which is scheduled to land in Go 1.11.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">
<br>
<br>
</span>Best,<br>
<br>
  Arnaud<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Best regards,<br>Michael</div>
</div></div>