<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 2, 2018 at 4:38 AM, Arnaud <span dir="ltr"><<a href="mailto:arnaud.rebillout@collabora.com" target="_blank">arnaud.rebillout@collabora.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
Hi,<br>
<br>
I addressed all your comments, thanks very much for the feedback.
More details bellow.<span class="gmail-"><br>
<br>
<div class="gmail-m_-4263858333151903184moz-cite-prefix">On 02/28/2018 04:05 PM, Michael
Stapelberg wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr"><br>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
#### containerd<br>
<<a href="https://salsa.debian.org/elboulangero-guest/containerd" rel="noreferrer" target="_blank">https://salsa.debian.org/elbo<wbr>ulangero-guest/containerd</a>><br>
<span class="gmail-m_-4263858333151903184gmail-">- As for testing the thing really, I
didn't go far yet, I just launched<br>
the binary, the log messages that appeared looked
healthy enough,<br>
and that's all for now.<br>
</span></blockquote>
<div><br>
</div>
<div>Some of the comments below apply
(unnecessary-team-upload, DEP-3 headers for patches).</div>
</div>
</div>
</div>
</blockquote>
<br></span>
Fixed.<span class="gmail-"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div>Also, this requires
golang-github-containerd-<wbr>console-dev to build, which is
not in the archive and not in this list of packages?</div>
</div>
</div>
</div>
</blockquote>
<br></span>
golang-github-containerd-<wbr>console is available at<br>
<a class="gmail-m_-4263858333151903184moz-txt-link-rfc2396E" href="https://salsa.debian.org/go-team/packages/golang-github-containerd-console" target="_blank"><https://salsa.debian.org/go-<wbr>team/packages/golang-github-<wbr>containerd-console></a><br>
<br>
It was part of the very first packages I made, that's why it's in
`<a href="http://salsa.debian.org/go-team/packages" target="_blank">salsa.debian.org/go-team/<wbr>packages`</a>.<br>
<br>
The last time I heard from it it Debian FTP Masters, it said:<br>
<br>
Your package has been put into the NEW queue, which requires
manual action<br>
from the ftpteam to process. The upload was otherwise valid (it
had a good<br>
OpenPGP signature and file hashes are valid), so please be
patient.<br>
<br></div></blockquote><div><br></div><div>Yeah, I see that mail, but I can’t see the package in <a href="https://ftp-master.debian.org/new.822">https://ftp-master.debian.org/new.822</a>. Might be worth sending an email to ftp-master about this discrepancy.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF">
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote"><span class="gmail-">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-m_-4263858333151903184gmail-">
<br>
#### golang-github-docker-go-events<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-events" rel="noreferrer" target="_blank">https://salsa.debian.org/elbo<wbr>ulangero-guest/golang-github-<wbr>docker-go-events</a>><br>
</span></blockquote>
<div><br>
</div>
<div>Can you address these please?</div>
</span><div><span class="gmail-">
<div>P: golang-github-docker-go-events source:
file-contains-trailing-<wbr>whitespace debian/control (line
25)</div>
</span><div>W: golang-github-docker-go-events source:
unnecessary-team-upload</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
Fixed.<span class="gmail-"><br>
<br>
<blockquote type="cite">
<div>I: golang-github-docker-go-events source:
vcs-field-uses-insecure-uri vcs-git git://<a href="http://anonscm.debian.org/pkg-go/packages/golang-github-docker-go-events.git" target="_blank">anonscm.debian.org/pkg-<wbr>go/packages/golang-github-<wbr>docker-go-events.git</a></div>
</blockquote>
<br></span>
I don't have this warning, neither from lintian Stretch, neither
from lintian backported from Buster. What do I miss ?<br></div></blockquote><div><br></div><div>Are you enabling all the options I have enabled? See <a href="https://github.com/stapelberg/configfiles/blob/master/lintianrc">https://github.com/stapelberg/configfiles/blob/master/lintianrc</a></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF">
<br>
Anyway, I compared with other packages and fixed it.<span class="gmail-"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-m_-4263858333151903184gmail-">
<br>
#### golang-github-docker-go-metric<wbr>s<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-metrics" rel="noreferrer" target="_blank">https://salsa.debian.org/elbo<wbr>ulangero-guest/golang-github-<wbr>docker-go-metrics</a>><br>
</span></blockquote>
<div><br>
</div>
<div>Can’t build this until
golang-github-prometheus-<wbr>client-golang is fixed. Some of
the lintian warnings above seem to apply here, too,
though.</div>
</div>
</div>
</div>
</blockquote>
<br></span>
Lintian warnings fixed.<span class="gmail-"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="gmail-m_-4263858333151903184gmail-"><br>
#### golang-github-prometheus-clien<wbr>t-golang<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang" rel="noreferrer" target="_blank">https://salsa.debian.org/elbo<wbr>ulangero-guest/golang-github-<wbr>prometheus-client-golang</a>><br>
</span></blockquote>
<div><br>
</div>
<div>This package cannot be cloned with gbp as-is:</div>
<div>
<div><br>
</div>
<div>% gbp clone <a href="https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-prometheus-client-<wbr>golang</a></div>
<div>gbp:info: Cloning from '<a href="https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-prometheus-client-<wbr>golang</a>'</div>
<div>gbp:error: Git command failed: Error running git
checkout: error: pathspec 'master' did not match any
file(s) known to git.</div>
</div>
<div><br>
</div>
<div>I think you’ll need to set debian-branch in
debian/gbp.conf.</div>
</div>
</div>
</div>
</blockquote>
<br></span>
OK, I just changed the default branch in the GitLab settings, and
set it to `debian/sid`, which is the branch I worked on, and which
comes with a proper gbp.conf. The default branch before was
`debian/jessie-backports`, and it doesn't have a gpb.conf.<br>
<br>
So now gbp cone works.<br>
<br>
This package has no `master` branch, only a
`debian/jessie-backports` and `debian/sid`. I think it's what DEP-14
recommends so I prefer not to change anything here, even more
because I'm bumping someone else package.</div></blockquote><div><br></div><div>Thanks, the package indeed builds now.</div><div><br></div><div>Could you send an email to tincho@ about reviewing/merging these changes please? I think your update of the upstream branch is different from how tincho uses the upstream branch.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote"><span class="gmail-m_-4263858333151903184gmail-"></span><br>
<span class="gmail-m_-4263858333151903184gmail-"></span>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-m_-4263858333151903184gmail-">
</span><span class="gmail-m_-4263858333151903184gmail-">#### continuity<br>
<<a href="https://salsa.debian.org/elboulangero-guest/continuity" rel="noreferrer" target="_blank">https://salsa.debian.org/elbo<wbr>ulangero-guest/continuity</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890983" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-b<wbr>in/bugreport.cgi?bug=890983</a>><br>
</span><span class="gmail-m_-4263858333151903184gmail-">- I ran the series of test
described at<br>
<<a href="https://github.com/containerd/continuity" rel="noreferrer" target="_blank">https://github.com/containerd<wbr>/continuity</a>>,<br>
everything went fine.<br>
</span></blockquote>
<div><br>
</div>
<div>It would be good to add a manpage for the continuity
binary. Otherwise, the package looks fine.</div>
</div>
</div>
</div>
</blockquote>
<br></span>
Agreed, well, I'm running out of time on that project, so I skip for
now, if it's ok with you.<span class="gmail-"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-m_-4263858333151903184gmail-">
<br>
#### golang-gogottrpc<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-gogottrpc" rel="noreferrer" target="_blank">https://salsa.debian.org/elbo<wbr>ulangero-guest/golang-gogottrp<wbr>c</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890958" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-b<wbr>in/bugreport.cgi?bug=890958</a>><br>
</span><span class="gmail-m_-4263858333151903184gmail-">- Patch and issues submitted
upstream.<br>
</span></blockquote>
<div><br>
</div>
<div>Can you add DEP-3 tags to the patches please? See <a href="http://dep.debian.net/deps/dep3/" target="_blank">http://dep.debian.net/<wbr>deps/dep3/</a>.
No need to go overboard, just the
last-updated/author/<wbr>description/forwarded ones.</div>
</div>
</div>
</div>
</blockquote>
<br></span>
Fixed.<span class="gmail-"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>Also, there seems to be a lintian false-positive: it
reports statically-linked-binary despite the Build-Depends
on golang-go. Can you file a lintian bug about that
please?</div>
</div>
</div>
</div>
</blockquote>
<br></span>
Ok, I'm doing that right now.<br>
<br>
BTW, in this package I use the following Build-Depends for
`golang-go`:<br>
<br>
golang-go (>= 2:1.9~) | golang-1.9-go,<br>
<br>
Using the epoch `2` in the version here. Is it actually needed ? I'm
not 100% sure, but I think I saw other packages that don't mention
epoch and just do something like `>1.9`, which is more concise.
I'm also not sure about the tilde at then end, I just copy-pasted
that from somewhere :)</div></blockquote><div><br></div><div>The epoch is required; leaving it out results in a trivially fulfilled dependency:</div><div><br></div><div><div>% dpkg --compare-versions '2:1.10' '>=' '1.9' && echo yes || echo no </div><div>yes</div><div>% dpkg --compare-versions '2:1.8' '>=' '1.9' && echo yes || echo no </div><div>yes</div></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-m_-4263858333151903184gmail-">
<br>
</span><span class="gmail-m_-4263858333151903184gmail-">####
golang-github-containerd-btrfs<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs" rel="noreferrer" target="_blank">https://salsa.debian.org/elbo<wbr>ulangero-guest/golang-github-<wbr>containerd-btrfs</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890989" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-b<wbr>in/bugreport.cgi?bug=890989</a>><br>
</span>- I disabled the test to avoid installing a
btrfs-test binary. I don't<br>
think it makes sense to create an additional binary
package<br>
just for shipping this test.<br>
</blockquote>
<div><br>
</div>
<div>Sounds good. Maybe change cmd to cmd/btrfs-test so that
we’ll notice newly introduced binaries upon updates?
Otherwise, the package looks good.</div>
</div>
</div>
</div>
</blockquote>
<br></span>
Indeed, good catch ! Done.<span class="gmail-"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<span class="gmail-m_-4263858333151903184gmail-"><br>
#### golang-github-containerd-typeu<wbr>rl<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl" rel="noreferrer" target="_blank">https://salsa.debian.org/elbo<wbr>ulangero-guest/golang-github-<wbr>containerd-typeurl</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891181" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-b<wbr>in/bugreport.cgi?bug=891181</a>><br>
- Patch submitted upstream<br>
</span></blockquote>
<div><br>
</div>
<div>Please add DEP-3 tags to the patch. Looks good
otherwise.</div>
<div> </div>
</div>
</div>
</div>
</blockquote>
<br></span>
Done.<span class="gmail-"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-m_-4263858333151903184gmail-">
<br>
#### golang-github-dmcgowan-go-tar<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar" rel="noreferrer" target="_blank">https://salsa.debian.org/elbo<wbr>ulangero-guest/golang-github-<wbr>dmcgowan-go-tar</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890960" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-b<wbr>in/bugreport.cgi?bug=890960</a>><br>
- This one was a tricky one, please read the commit
messages for details.<br>
</span></blockquote>
<div><br>
</div>
<div>Does the package which needs this require support for
sparse tar files? If not, I think we can do away with this
package in favor of patching the consumer to use
archive/tar instead. Doing a diff -ur shows that this
package is identical to archive/tar as of Go 1.10, except
for the sparse support, which is scheduled to land in Go
1.11.</div>
</div>
</div>
</div>
</blockquote>
<br></span>
You're right, and there's no need for sparse support. I patched as
you suggested to use archive/tar.<br>
<br>
Best regards,<br>
<br>
Arnaud<br>
<br>
</div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Best regards,<br>Michael</div>
</div></div>