<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 19, 2018 at 3:29 AM, Arnaud Rebillout <span dir="ltr"><<a href="mailto:arnaud.rebillout@collabora.com" target="_blank">arnaud.rebillout@collabora.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF"><span class="gmail-">
<p>Hello all, let me follow up on this !</p>
<p>According to discussions on this mailing list, I made the
following changes on the packages:</p></span>
- the license issues have been clarified with containerd projects,
except for containerd-typeurl which doesn't receive much attention
from upstream. As a consequence I let the copyright to 'containerd',
except if there's a better thing to do (like, nothing in the
copyright field ?).<span class="gmail-"><br>
- I re-packaged docker-go-metrics to a lower version, so that there
is no need to bump prometheus-client-golang.<br>
- I think I addressed most (if all) of the comments from Michael,
ie. DEP-3 patches, more lintian warnings fixed, and others all along
the discussion.<br>
<p>So let me sum up here the list of packages we're talking about,
and that received changes.<br>
</p>
<p>FORGET ABOUT (because it's not needed anymore)<br>
</p>
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar" target="_blank"><https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-dmcgowan-go-tar></a><br>
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang" target="_blank"><https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-prometheus-client-<wbr>golang></a><br>
<br>
CLONE AGAIN (don't pull because I re-wrote history)<br>
<br>
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-metrics" target="_blank"><https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-docker-go-metrics></a></span></div></blockquote><div><br></div><div>Uploaded.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-"><br>
<br></span>
PULL - there are a few changes<span class="gmail-"><br>
<br>
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/elboulangero-guest/containerd" target="_blank"><https://salsa.debian.org/<wbr>elboulangero-guest/containerd></a></span></div></blockquote><div><br></div><div>I’ll hold off with this one until the build-deps are satisfied.</div><div><br></div><div>By the way, do you want to include the most recent commits in the debian/changelog entry?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-">
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/elboulangero-guest/continuity" target="_blank"><https://salsa.debian.org/<wbr>elboulangero-guest/continuity></a></span></div></blockquote><div><br></div><div>Looks good. Can you move this repository to its intended location <a href="https://salsa.debian.org/go-team/packages/continuity">https://salsa.debian.org/go-team/packages/continuity</a> please?</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-">
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs" target="_blank"><https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-containerd-btrfs></a></span></div></blockquote><div><br></div><div> The description for golang-github-containerd-btrfs-dev should be trimmed: upstream’s recommendation to vendor the package doesn’t make sense in Debian, and neither does the contribution guidelines.</div><div><br></div><div>Looks good otherwise. Can you move it to <a href="https://salsa.debian.org/go-team/packages/golang-github-containerd-btrfs">https://salsa.debian.org/go-team/packages/golang-github-containerd-btrfs</a> please?</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-">
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl" target="_blank"><https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-containerd-typeurl></a></span></div></blockquote><div><br></div><div> Looks good. Can you move this to <a href="https://salsa.debian.org/go-team/packages/golang-github-containerd-typeurl">https://salsa.debian.org/go-team/packages/golang-github-containerd-typeurl</a> please?</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-">
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-events" target="_blank"><https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-docker-go-events></a></span></div></blockquote><div><br></div><div> Uploaded.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-">
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec" target="_blank"><https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-opencontainers-image-<wbr>spec></a></span></div></blockquote><div><br></div><div> This one is missing a debian/changelog entry for your changes.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-">
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/elboulangero-guest/golang-gogottrpc" target="_blank"><https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>gogottrpc></a></span></div></blockquote><div><br></div><div>Looks good. Can you move this to <a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/elboulangero-guest/golang-gogottrpc" target="_blank" style="color:rgb(17,85,204);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255)">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>gogottrpc</a> please?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-"><br>
<br></span>
PULL - these packages have been rejected due to copyright issues<span class="gmail-"><br>
<br>
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/go-team/packages/golang-github-containerd-console" target="_blank"><https://salsa.debian.org/go-<wbr>team/packages/golang-github-<wbr>containerd-console></a></span></div></blockquote><div><br></div><div>Uploaded.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-">
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/go-team/packages/golang-github-containerd-fifo" target="_blank"><https://salsa.debian.org/go-<wbr>team/packages/golang-github-<wbr>containerd-fifo></a></span></div></blockquote><div><br></div><div>Uploaded.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-">
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/go-team/packages/golang-github-containerd-go-runc" target="_blank"><https://salsa.debian.org/go-<wbr>team/packages/golang-github-<wbr>containerd-go-runc></a></span></div></blockquote><div><br></div><div>Uploaded.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-"><br>
<br></span>
PULL - this package is already in Debian Sid, should I issue a new
Debian release due to copyright change ?<span class="gmail-"><br>
<br>
<a class="gmail-m_6678813240706004075moz-txt-link-rfc2396E" href="https://salsa.debian.org/go-team/packages/golang-github-containerd-cgroups" target="_blank"><https://salsa.debian.org/go-<wbr>team/packages/golang-github-<wbr>containerd-cgroups></a></span></div></blockquote><div><br></div><div>Yes please. It’s always good to not leave pending changes lying around (for people touching the package in the future).</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-"><br>
<br>
Ok I think I didn't forget anything :)<br>
<br>
Feel free to tell me if there's anything that is still not ok with
these packages, if there's anything I should do. Like, should I
always finish with a commit that updates the changelog</span></div></blockquote><div><br></div><div>Yes please.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-"> (which I
didn't do), or not ? Is it OK to have a debian release ending with
'-2' or more if the package was *never* uploaded before (I know that
reprepro doesn't like that, but I guess the Debian infra doesn't use
reprepro).<br></span></div></blockquote><div><br></div><div>Debian doesn’t use reprepro, but it would be easier to use -1 until the package was uploaded. Otherwise, the uploader needs to remember to use the -v option to include all changelog entries in the .changes file.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-">
<br>
Thanks a lot for the time and energy spend on that.<br>
<br>
Arnaud<br>
<br>
</span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Best regards,<br>Michael</div>
</div></div>