[pkg-golang-devel] Add tzdata to golang-go install dependencies?

[Potter, Tim (HPE Linux Support)]

On 6 Oct 2016, at 8:51 AM, Michael Hudson-Doyle <michael.hudson at canonical.com> wrote:
> 
> On 6 October 2016 at 06:35, Tianon Gravi <tianon at debian.org> wrote:
> On 5 October 2016 at 03:50, Potter, Tim (HPE Linux Support)
> <timothy.potter at hpe.com> wrote:
> > Thoughts?
> 
> I'm not opposed to the idea!  Generally, given the
> technically-optional relationship "tzdata" has to "golang", I'd
> probably normally put it in Recommends, but that wouldn't help
> Build-Depends any. :)
> 
> I think it'd probably make more sense to put the relation on
> "golang-src" though, since that's technically where the "time" code
> itself comes from (and where the dependency on "tzdata" is actually
> introduced).
> 
> Something I wonder about here is that do we need to add tzdata as a Depends: on some of the packages that provide binaries? It's all well and good to make the builds pass but it's nice if the binaries work too :)

OK so that fixes packages that use tzdata in tests, but what about packages that use it in their
binary but not in tests?  This would only be detected by a crash (or whatever it's called on Go)
in the app when it hits the timezone code.  I don't think that's a good solution for that case.

I like tianon's idea of adding it to the recommended section.

> I'm not sure I see anything less tedious that doing this case by case though.

I'm used to it.  (-:


Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.alioth.debian.org/pipermail/pkg-golang-devel/attachments/20161006/26192cce/attachment.sig>