Bug#749511: netcdf: wrong quote characters

[Sebastiaan Couwenberg]

Control: tags -1 upstream unreproducible moreinfo

Hi Michael,

We migrated away from NetCDF 4.1.3 to 4.4.0 in unstable, and I cannot
reproduce the issue with the current netcdf packages any more.

On Tue, 27 May 2014 15:58:24 +0100 Michael Tautschnig wrote:
> During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
> the build failed with the following error. Please note that we use our research
> compiler tool-chain (using tools from the cbmc package), which permits extended
> reporting on type inconsistencies at link time.
> 
> [...]
> libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I../fortran -I.. -I../libsrc -DgFortran -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -c curlfunctions.c  -fPIC -DPIC -o .libs/liboc_la-curlfunctions.o
> curlfunctions.c: In function 'ocset_curl_flags':
> curlfunctions.c:30:66: warning: character constant too long for its type [enabled by default]
>   cstat = curl_easy_setopt(curl, CURLOPT_ENCODING, 'deflate, gzip');
>                                                                   ^
> literals with 13 characters are not supported
> Makefile:388: recipe for target 'liboc_la-curlfunctions.lo' failed
> make[3]: *** [liboc_la-curlfunctions.lo] Error 1
> make[3]: Leaving directory '/srv/jenkins-slave/workspace/sid-goto-cc-netcdf/netcdf-4.1.3/oc'
> Makefile:551: recipe for target 'all-recursive' failed
> make[2]: *** [all-recursive] Error 1
> 
> Likely this should be double quotes here in order to set the accepted encoding
> to the desired value (the current code will set it to a value other than the
> desired one!) - and curl's documentation also suggests that the option has
> actually be renamed to CURLOPT_ACCEPT_ENCODING.

Double quotes are now used in oc2/occurlfunctions.c:

146     case CURLOPT_ENCODING:
147 #ifdef CURLOPT_ENCODING
148         if(state->curlflags.compress) {
149             CHECK(state, CURLOPT_ENCODING,"deflate, gzip");
150         }
151 #endif

It looks like this fixed the issue.

Can you confirm that this is now fixed, or can you still reproduce the
issue with netcdf (1:4.4.0~rc3-1)?

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1