RFS: pycoast (Was: RFS: pyorbital)

[Sebastiaan Couwenberg]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

The pytroll/pycoast GitHub repository doesn't have any tags yet,
making uscan unstable to detect new upstream releases. Can you ask
upstream to add the tags for the past releases and use them for any
future releases?

The package description refers to the old GSHHS dataset, which has
been renamed to GSHHG in recent releases (and packaged as gmt-gshhg),
the GSHHG dataset also contains WDBII data. Too bad pycoast only seems
to support the shapefiles and not the NetCDF datasets already packaged
in Debian.

While the benefit for small Python modules is negligible, it's a good
idea to always use dh --parallel in debian/rules files because
otherwise support for DEB_BUILD_OPTIONS="parallel=<N>" is not enabled.
For larger packages this is essential to keep the build time down.

Unfortunately the aggdraw Python module is not packaged for Debian
yet, so we can't run the test/test_pycoast.py script successfully.
Otherwise the following in debian/rules would have been sufficient to
configure pybuild to run it:

 export PYBUILD_TEST_PYTEST=1
 export PYBUILD_TEST_ARGS=$(CURDIR)/test/test_pycoast.py

Other than above, your package looks good so I've sponsored the upload.

Kind Regards,

Bas

- -- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCgAGBQJWyca3AAoJEGdQ8QrojUrxQzoP/jK4GTLR0e5q2eXgJz+iJP1s
etWpRhBAqn+n+hj0RywlUxXKPDoHRKoUJCdkMJZPMdvCrivYj6TIi5CnBq3uurov
n4azhJXIVkPHf49sGXxeNCd0UQoCuA87cJq9hEUSbW5pnD21iTWl4/kjJp58GI09
JXMlVebTZxogR+smUwkvKahpjqJ2WGMdOmM+PUQGSPxKbNQ7eFOX4Gy/8CYrwgES
BdFx1DJR1mwIUvcy4FGu1+hcsnAsWRJwObwq0eu1NqgEPo2nnNttL0jpJC1C6mEN
wa5GgiJ9nbZOGHY5f6arqFBUJ1a3rQX/8Oc75x2o7JuRq3dZ0e2R/Hd8DE+0I5zJ
zdf+SlHJvguKee5v/dXHvtdPHom5MzhTj+NTgrxV8ISoJT6BMJ772sjzcsQ3Kpfr
/tb8/AZH7rZ9BFDprYjxh1ap8FdzZDFmId8Nkyyu/yF5TCZpyB3KvxA8qZFtvx5k
RIJK0+zoYAD3tQhRpC+2R7Lcs7d+yCtEADYhyz5yxGFTrzriqlD8PfpLIG8ebHBs
IWTj7+v6hSzbDbY4IUq9/us/znbJQuA2fmshWLJSxw4I4A+bHgaO1zQE013V4Gzy
7TW6VwS2DZzeGKd2fgTEFwWnf7T+cQW9r0wubqKY59Z2V/KKH0tsA5abUxEp4AaZ
RrEIapmWfrRUXEpQbC8I
=2SFA
-----END PGP SIGNATURE-----