Bug#813066: proj-rdnap: FTBFS due to testsuite failures

[Sebastiaan Couwenberg]

Control: tags -1 confirmed

Hi Andreas,

Thanks for reporting this issue.

Due to changes in PROJ.4 4.9.2 the tests where the coordinates are
outside of the region where interpolation between either the NLGEO2004
geoid or the RD correction grid points is possible now get different output.

For example, with PROJ.4 4.8.0 (in jessie) we had:

 Test:   07 No_rd&geoid
 Exec:   cs2cs -r +init=epsg:4258 +to +init=rdnap:rdnap -f %.4f
 Input:  50.687420405 4.608971812
 STDERR: Rel. 4.8.0, 6 March 2012
 <cs2cs>: while processing file: <stdin>, line 1
 pj_transform(): point not within available datum shift grids
 Output: *       * -0.0001
 Expect: 100000.6700     300000.8900
 Test OK: From ETRS89 to RD/NAP - 07 No_rd&geoid (Expected output
overriden: *   * ^-?\d+\.\d+$)

PROJ.4 4.9.0 RC2 reported the same output, but with 4.9.2 we now get:

 Test:   07 No_rd&geoid
 Exec:   cs2cs -r +init=epsg:4258 +to +init=rdnap:rdnap -f %.4f
 Input:  50.687420405 4.608971812
 Output: 100000.6700     300000.8899 2147479807.9999
 Expect: 100000.6700     300000.8900
 Test OK: From ETRS89 to RD/NAP - 07 No_rd&geoid (Expected output
overriden: *   * ^-?\d+\.\d+$)

This is good, we now get correct values for this test which was not
possible before (in the direction from ETRS89 to RD/NAP). In the other
direction the results are not so good, with 4.8.0 we had:

 Test:   07 No_rd&geoid
 Exec:   cs2cs -s +init=rdnap:rdnap +to +init=epsg:4258 -f %.9f
 Input:  100000.6700 300000.8900
 STDERR: Rel. 4.8.0, 6 March 2012
 <cs2cs>: while processing file: <stdin>, line 1
 pj_transform(): point not within available datum shift grids
 Output: *       * 0.000000000
 Expect: 50.687420405    4.608971812
 Test OK: From RD/NAP to ETRS89 - 07 No_rd&geoid (Expected output
overriden: *   * ^-?\d+\.\d+$)

And with 4.9.2 we now get:

 Test:   07 No_rd&geoid
 Exec:   cs2cs -s +init=rdnap:rdnap +to +init=epsg:4258 -f %.9f
 Input:  100000.6700 300000.8900
 Output: -50.688542790   -175.391028187 2134749119.469262600
 Expect: 50.687420405    4.608971812
 Latitude not expected: -50.688542790, expected: *
 Longitude not expected: -175.391028187, expected: *
 Test FAILED: From RD/NAP to ETRS89 - 07 No_rd&geoid (Expected output
overriden: *       * ^-?\d+\.\d+$)

I need to update the overrides for tests 07-10 which all use points
outside the RD correction grid to handle the new output too.

The documentation for the mandatory tests [0] states that coordinates
can be computed for points outside the RD correction grid, but the
output should be handled with care.

I don't have time to fix the tests before leaving for FOSDEM, I should
be able to after I return.

[0]
https://anonscm.debian.org/cgit/pkg-grass/proj-rdnap.git/plain/Use%20of%20RDTRANS2008%20and%20NAPTRANS2008.pdf

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1