Bug#838247: josm: Help->Help gives "an unexpected exception occurred"

[Sebastiaan Couwenberg]

Based on the stacktrace in the debug information, it seems that the
exception is caused by the help-browser.css not being included as a
resource in the jar for the Debian package.

The stacktrace includes:

org.openstreetmap.josm.gui.help.HelpBrowser.buildStyleSheet(HelpBrowser.java:144)

And HelpBrowser.java line 144 does:

 getClass().getResourceAsStream("/data/help-browser.css"),
  StandardCharsets.UTF_8

We'll need to patch this to use the file under /usr/share/josm.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1
-------------- next part --------------
Build-Name:Debian
Build-Date:2016-09-06 08:31:26
Revision:10966
Is-Local-Build:false
Debian-Release:0.0.svn10966+dfsg-1

Identification: JOSM/1.5 (10966 Debian en) Linux Debian GNU/Linux unstable (sid)
Memory Usage: 586 MB / 1776 MB (363 MB allocated, but free)
Java version: 1.8.0_102-8u102-b14.1-2-b14, Oracle Corporation, OpenJDK 64-Bit Server VM
Screen: :0.0 1920x1200
Maximum Screen Size: 1920x1200
Java package: openjdk-8-jre:amd64-8u102-b14.1-2
Java ATK Wrapper package: libatk-wrapper-java:all-0.33.3-9
VM arguments: [-Djosm.restart=true, -Djava.net.useSystemProxies=true]

Plugins:
+ AddrInterpolation (32699)
+ DirectUpload (32699)
+ FixAddresses (32796)
+ HouseNumberTaggingTool (32699)
+ OpeningHoursEditor (32699)
+ RoadSigns (32796)
+ SimplifyArea (32796)
+ apache-commons (32699)
+ buildings_tools (32944)
+ download_along (32946)
+ editgpx (32699)
+ ejml (32680)
+ geojson (43)
+ geotools (32813)
+ jts (32699)
+ ods-bag (0.6.8)
+ opendata (32898)
+ opendataservices (0.6.8)
+ poly (32699)
+ reverter (32796)
+ terracer (32699)
+ todo (30000)
+ turnlanes (32796)
+ turnrestrictions (32796)
+ utilsplugin2 (32815)
+ walkingpapers (32796)
+ waydownloader (32699)
+ wikipedia (32884)

Tagging presets:
+ /usr/share/josm/data/defaultpresets.xml

Map paint styles:
- /usr/share/josm/styles/standard/potlatch2.mapcss

Last errors/warnings:
- W: PluginException: : org.openstreetmap.josm.plugins.PluginException: The plugin file '/usr/share/josm/plugins/lakewalker.jar' does not include a Manifest.
- W: Failed to scan file 'lakewalker.jar' for plugin information. Skipping.
- W: PluginException: : org.openstreetmap.josm.plugins.PluginException: The plugin file '/usr/share/josm/plugins/editgpx.jar' does not include a Manifest.
- W: Failed to scan file 'editgpx.jar' for plugin information. Skipping.
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.ods.gui.AbstractDownloadDialog$DownloadAction at 1dabc2f8
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.ods.gui.AbstractDownloadDialog$CancelAction at 4240b0d5
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.help.ContextSensitiveHelpAction at 56f0c648
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.ods.gui.AbstractDownloadDialog$DownloadAction at 2acee481
- W: Old style SideButton usage for action org.openstreetmap.josm.plugins.ods.gui.AbstractDownloadDialog$CancelAction at 75ad0ea9
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.help.ContextSensitiveHelpAction at 6b0fc76b


=== REPORTED CRASH DATA ===
BugReportExceptionHandler#handleException:
No data collected.

Warning issued by: BugReportExceptionHandler#handleException

=== STACK TRACE ===
Thread: AWT-EventQueue-0 (18) of main
java.lang.NullPointerException
	at java.io.Reader.<init>(Reader.java:78)
	at java.io.InputStreamReader.<init>(InputStreamReader.java:113)
	at org.openstreetmap.josm.gui.help.HelpBrowser.buildStyleSheet(HelpBrowser.java:144)
	at org.openstreetmap.josm.gui.help.HelpBrowser.build(HelpBrowser.java:176)
	at org.openstreetmap.josm.gui.help.HelpBrowser.<init>(HelpBrowser.java:92)
	at org.openstreetmap.josm.gui.help.HelpBrowser.getInstance(HelpBrowser.java:102)
	at org.openstreetmap.josm.gui.help.HelpBrowser.setUrlForHelpTopic(HelpBrowser.java:113)
	at org.openstreetmap.josm.actions.HelpAction.actionPerformed(HelpAction.java:70)
	at javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:2022)
	at javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2348)
	at javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:402)
	at javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:259)
	at javax.swing.AbstractButton.doClick(AbstractButton.java:376)
	at javax.swing.plaf.basic.BasicMenuItemUI.doClick(BasicMenuItemUI.java:833)
	at javax.swing.plaf.basic.BasicMenuItemUI$Handler.mouseReleased(BasicMenuItemUI.java:877)
	at java.awt.Component.processMouseEvent(Component.java:6533)
	at javax.swing.JComponent.processMouseEvent(JComponent.java:3324)
	at java.awt.Component.processEvent(Component.java:6298)
	at java.awt.Container.processEvent(Container.java:2236)
	at java.awt.Component.dispatchEventImpl(Component.java:4889)
	at java.awt.Container.dispatchEventImpl(Container.java:2294)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.LightweightDispatcher.retargetMouseEvent(Container.java:4888)
	at java.awt.LightweightDispatcher.processMouseEvent(Container.java:4525)
	at java.awt.LightweightDispatcher.dispatchEvent(Container.java:4466)
	at java.awt.Container.dispatchEventImpl(Container.java:2280)
	at java.awt.Window.dispatchEventImpl(Window.java:2746)
	at java.awt.Component.dispatchEvent(Component.java:4711)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:758)
	at java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.awt.EventQueue$3.run(EventQueue.java:709)
	at java.awt.EventQueue$3.run(EventQueue.java:703)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86)
	at java.awt.EventQueue$4.run(EventQueue.java:731)
	at java.awt.EventQueue$4.run(EventQueue.java:729)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:728)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)