Bug#838463: libosmium: FTBFS when built with dpkg-buildpackage -A (chmod: No such file or directory)

[Santiago Vila]

Package: src:libosmium
Version: 2.9.0-1
Severity: serious
Tags: patch

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
(which is what the "Arch: all" autobuilder would do to build it)
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --parallel
   dh_testdir -i -O--parallel
   dh_update_autotools_config -i -O--parallel
   debian/rules override_dh_auto_configure
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_auto_configure -- -DCMAKE_VERBOSE_MAKEFILE=1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   debian/rules override_dh_auto_build-indep
make[1]: Entering directory '/<<PKGBUILDDIR>>'
if [ -e "build" ]; then \
	(cd build && /usr/bin/make doc) ; \
else \

[... snipped ...]

make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_auto_test -i -O--parallel
 fakeroot debian/rules binary-indep
dh binary-indep --parallel
   dh_testroot -i -O--parallel
   dh_prep -i -O--parallel
   dh_auto_install -i -O--parallel
   debian/rules override_dh_installdocs
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_installdocs
# Remove embedded jquery.js in favor of libjs-jquery
rm -f debian/*/usr/share/doc/*/html/jquery.js
# Remove useless autogenerated doxygen file
rm -f debian/*/usr/share/doc/*/html/*.md5
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   debian/rules override_dh_installchangelogs
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_installchangelogs -k CHANGELOG.md
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   debian/rules override_dh_installexamples
make[1]: Entering directory '/<<PKGBUILDDIR>>'
dh_installexamples
# Remove executable bit from .cpp files
chmod 0644 debian/*/usr/share/doc/*/examples/*.cpp
chmod: cannot access 'debian/*/usr/share/doc/*/examples/*.cpp': No such file or directory
debian/rules:47: recipe for target 'override_dh_installexamples' failed
make[1]: *** [override_dh_installexamples] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
debian/rules:11: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
--------------------------------------------------------------------------------

The only package having examples is libosmium2-dev. Since we are
creating arch-independent packages only, there is not anything to chmod
so the chmod command fails.

Tha patch below (untested but trivial and self-explanatory) should
probably fix this.

Early discovery of these kind of bugs is one of the reasons I encourage
everybody to upload in source-only form.

Thanks.

--- a/debian/rules
+++ b/debian/rules
@@ -43,7 +43,7 @@ override_dh_installdocs:
 	# Remove useless autogenerated doxygen file
 	$(RM) debian/*/usr/share/doc/*/html/*.md5
 
-override_dh_installexamples:
+override_dh_installexamples-arch:
 	dh_installexamples
 	
 	# Remove executable bit from .cpp files