Bug#859433: ogdi-dfsg shouldn't disable PIE

[Adrian Bunk]

Source: ogdi-dfsg
Version: 3.2.0+ds-1
Severity: normal
Tags: patch

With gcc in stretch defaulting to PIE, hardening=+all,-pie changed
semantics from "enable hardening but not PIE" to "enable all hardening
and explicitely disable the default PIE".
The latter is usually not intended.

The -pie in hardening flags was in some cases required in pre-stretch
releases to avoid build failures caused by (incorrectly) passing -fPIE
to the compiler when building shared libraries or plugins.
This problem does no longer exist.

Please consider applying the following patch:

--- debian/rules.old	2017-04-03 13:11:13.000000000 +0000
+++ debian/rules	2017-04-03 13:11:18.000000000 +0000
@@ -5,7 +5,7 @@
 #export DH_VERBOSE=1
 
 # Enable hardening build flags
-export DEB_BUILD_MAINT_OPTIONS=hardening=+all,-pie
+export DEB_BUILD_MAINT_OPTIONS=hardening=+all
 
 export TOPDIR=$(CURDIR)
 export CFG=debug