Bug#860273: osm2pgsql: Data disappears with --append --output multi

[Paul Norman]

Package: osm2pgsql
Version: 0.92.0+ds-1
Severity: important
Tags: patch upstream

Dear Maintainer,

When data is loaded with osm2pgsql with --slim --output multi and then updated
with --append --slim --output multi updated data disappears from the rendering
tables with no obvious cause. A case that reproduces this is loading the XML
in https://github.com/openstreetmap/osm2pgsql/issues/735#issuecomment-293423587
and updating with the diff in https://github.com/openstreetmap/osm2pgsql/issues/735#issue-220089109

This is caused by incorrect logic for queuing pending ways in the multi backend.
Instead of using the same logic as the pgsql backend ( > in an if condition)
different logic ( == in the corresponding condition) was used.

This has been fixed upstream and backported to 0.92.x with
https://github.com/openstreetmap/osm2pgsql/commit/8ffe16e67da43fd531a5e73b10d31465324f4a91

This bug applies to all currently released versions of osm2pgsql except 0.92.1.
It is mitigated by most people using --output pgsql or not consuming updates
with --append.

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?
   * What exactly did you do (or not do) that was effective (or
     ineffective)?
   * What was the outcome of this action?
   * What outcome did you expect instead?

*** End of the template - remove these template lines ***


-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages osm2pgsql depends on:
ii  libboost-filesystem1.62.0  1.62.0+dfsg-4
ii  libboost-system1.62.0      1.62.0+dfsg-4
ii  libbz2-1.0                 1.0.6-8.1
ii  libc6                      2.24-9
ii  libexpat1                  2.2.0-2
ii  libgcc1                    1:6.3.0-11
ii  libgeos-3.5.1              3.5.1-3
ii  liblua5.2-0                5.2.4-1.1+b2
ii  libpq5                     9.6.2-2
ii  libproj12                  4.9.3-1
ii  libstdc++6                 6.3.0-11
ii  zlib1g                     1:1.2.8.dfsg-5

Versions of packages osm2pgsql recommends:
ii  postgis  2.3.1+dfsg-1

osm2pgsql suggests no packages.

-- no debconf information