RFS: pyresample and mipp

[Sebastiaan Couwenberg]

On 09/23/2017 11:57 PM, Antonio Valentino wrote:

> Il 23/09/2017 20:28, Sebastiaan Couwenberg ha scritto:
>> Hi Antonio,
>>
>> On 09/23/2017 07:21 PM, Antonio Valentino wrote:
>>> pyresample 1.6.1-1 is a new upstream release
>>> mipp 1.0.0-2 includes a fix for a ci issue (compatibility with new numpy)
>>
>> Please address the lintian issues:
>>
>>  I: pyresample source: python-foo-but-no-python3-foo python-pyresample-test
> 
> this package only contains test data, so, IMO, non need to have a
> duplicate package for python3

Then document this in the comment for the lintian override.

>>  I: mipp source: python-foo-but-no-python3-foo python-mipp
>>  I: mipp source: python-foo-but-no-python3-foo python-mipp-test
> 
> mipp only works with python 2.

Like pyresample this needs to be documented in the comment for the
lintian override.

> Although it depends on six it uses e.g. the old exception syntax that is
> not compatible with python 3
> I could submit a patch upstream but I would prefer that python3 is
> officially supported before creating a debian package.

There should at least be an issue for Python 3 support upstream. 2020 is
not far away any more and the future of Python 2.7 in distributions
looks bleak after then.

>>  W: mipp source: build-depends-on-python-sphinx-only
> 
> not sure it makes sense for a python2 package to depend on
> python3-sphinx, even id it should work
> Should I change the build dependency to python3-sphinx only?

Just add python3-sphinx to the build dependencies, as suggested in the
extended description of the lintian tag:

 https://lintian.debian.org/tags/build-depends-on-python-sphinx-only.html

>>  W: mipp source: unnecessary-testsuite-autopkgtest-header
> 
> done
> 
> thanks Sebastiaan for the review

Thanks for working on these packages.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1