Bug#897830: otb: ftbfs with GCC-8 (error: return-statement with a value, in function returning 'void' [-fpermissive])

[Bas Couwenberg]

Control: tags -1 upstream
Control: forwarded -1 
https://gitlab.orfeo-toolbox.org/orfeotoolbox/otb/issues/1609

Now that #897899 is fixed and insighttoolkit4 no longer FTBFS with GCC 
8, I did test rebuild of OTB with GCC 8 which unfortunately still FTBFS:

  In file included from 
/build/otb-6.6.0~rc1+dfsg/Modules/Adapters/GdalAdapters/include/otbGeometriesSet.h:27,
                   from 
/build/otb-6.6.0~rc1+dfsg/Modules/Adapters/GdalAdapters/src/otbGeometriesSet.cxx:25:
  
/build/otb-6.6.0~rc1+dfsg/Modules/Adapters/GdalAdapters/include/otbImageReference.h: 
In member function 'void 
otb::ogr::ImageReference<TPrecision>::TransformPointToPhysicalPoint(const 
PointType&) const':
  
/build/otb-6.6.0~rc1+dfsg/Modules/Adapters/GdalAdapters/include/otbImageReference.h:147:12: 
error: return-statement with a value, in function returning 'void' 
[-fpermissive]
       return physicalPoint;
              ^~~~~~~~~~~~~

The issue has been forwarded upstream.

Kind Regards,

Bas