opencpn: binaries without source.

[Alec Leamas]

Hi!

Most of your remarks seems easy enough to handle. However, I wonder
about a few. Let's take them first:

On 25/11/18 14:58, Sebastiaan Couwenberg wrote:

>    There has been no upload of the package yet, so the +dfsg
>    repacksuffix is sufficient, the .1 should be stripped.

What about [1]? What is the reason to not comply with this?

>    The opencpn-plugins package depends a manual version, it should
>    ${binary:Version} instead.

Isn't this the merge case #6 at [2]?  Where the version should be
hardcoded?

>    Why is the get-orig-source target used? The bugreport mentioned is
>    not clear.

The short story is that a plain uscan doesn't work, and that this is a
known problem. It seems to be related to the combination of large
sources generated with something else than a recent gnu tar. The
work-around is basically to unpack and repack with gnu tar at which
point things can proceed as usual.

>    Why add an override for the javascript files when they can be
>    excluded from the repacked upstream tarball?

Because all other things removed are supported by build system patches
which have been upstreamed. Patches for removing these files will never
be accepted, and likely a pain to maintain.

Thoughts?

--alec

[1]
https://wiki.debian.org/DebianMentorsFaq#What_does_.2BIBw-dfsg.2BIB0_or_.2BIBw-ds.2BIB0_in_the_version_string_mean.3F

[2] https://wiki.debian.org/PackageTransition