opencpn: 5.0.0 update

[Sebastiaan Couwenberg]

On 12/8/19 8:27 AM, Alec Leamas wrote:
> I have  updated opencpn to current version 5.0.0. This update is
> somewhat urgent: the current package is old after 9 months in the NEW
> queue, and also uses gtk2 which we are in the process of getting rid of.

The bug (#946018) was not closed in the changelog.

> So, if someone has time to review and eventually upload this package I
> would appreciate it.

@Andreas, the tag for 4.8.8+dfsg.2-1 was never pushed, please push the
tag if you have from when you sponsored the upload.

Dependencies between the binary packages need to use ">=
${source:Version}" to support arch-all binNMUs as that will change the
version of arch:all packages to <version>+b<N> breaking the "=
${source:Version}" version requirement.

The package FTBFS:

 /build/opencpn-5.0.0+dfsg.1/plugins/grib_pi/src/GribOverlayFactory.cpp:42:10: fatal error: gdk/gdk.h: No such file or directory
    42 | #include <gdk/gdk.h>
       |          ^~~~~~~~~~~

This is provided by libgtk-3-dev not libgtk2.0-dev.

The package version should just be 5.0.0+dfsg without a revision, this
should be set by d/watch using repacksuffix.

Lintian reports a bunch of issues:

 * extra-license-file
 * package-contains-documentation-outside-usr-share-doc
 * unused-file-paragraph-in-dep5-copyright
 * unused-override hardening-no-fortify-functions
 * wildcard-matches-nothing-in-dep5-copyright

The get-orig-source target is obsolete, using plain uscan will do the
repacking correctly (`gbp import-orig --uscan` won't so do uscan
separately).

Make sure you do a full build in an uptodate sid chroot to ensure the
package is in good order.

I've pushed a bunch of changes to fix some of the issues I encountered,
but the package needs more work before it can be uploaded.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1