opencpn: 5.0.0 update

[Sebastiaan Couwenberg]

On 12/8/19 2:38 PM, Alec Leamas wrote:
> On 08/12/2019 13:15, Sebastiaan Couwenberg wrote:
>> On 12/8/19 12:39 PM, Alec Leamas wrote:
>>> On 08/12/2019 11:56, Sebastiaan Couwenberg wrote:
>>>> On 12/8/19 8:27 AM, Alec Leamas wrote:
>>>
>>>>> So, if someone has time to review and eventually upload this package I
>>>>> would appreciate it.
>>>
>>>> I've pushed a bunch of changes to fix some of the issues I encountered,
>>>> but the package needs more work before it can be uploaded.
>>>
>>> While I do appreciate remarks (really do!) I would also appreciate if I
>>> could do the changes myself in a review context like this. It's partly
>>> about having some control of the package and partly about the review as
>>> a learning opportunity. So, please...
>>
>> If you don't want other people to commit changes to the package it
>> shouldn't be team maintained.
> 
> I have no problems whatsoever with that.
> 
> What I said referred to  "the review context" (see above). In such a
> process, I'm used to that reviewers raises remarks and that the reviewee
> makes the actual changes. It is a proven concept.
> 
> That said, is it acceptable?

There are still plenty of issues left for you to fix before the package
is ready for upload as I mentioned before.

You need to adress many non-pedantic lintian issues, which includes
updating the copyright file to reflect the changes between 4.8.8 &
5.0.0. Standard practice when updating packaging for a new upstream
release is to review the diff between the previous version and the new
one and update the copyright file with any changes based thereon. You
may also spot new or dropped dependencies in those changes.

The files installed in the binary packages have issues, unless the extra
license files are required for the program to function (e.g. because it
displays the content in a help option) the files should not be
installed, if they are required symlinks to the files in
/usr/share/common-licenses should be used instead.

LINUX_DEVICES.md should either be moved to /usr/share/doc if it's not
used by the program, replaced by a symlink if it does, or the lintian
tag needs an override explaining why not having the file in
/usr/share/doc is not a problem.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1