Bug#931993: lintian: usr-share-doc-symlink-to-foreign-package false positive for dbgsym packages

[Bas Couwenberg]

Source: lintian
Version: 2.16.0
Severity: normal

Dear Maintainer,

For the saga packaging available in git, lintian reports:

 E: libsaga-gdi-7.3.0-dbgsym: usr-share-doc-symlink-to-foreign-package libsaga-gdi-7.3.0
 E: libsaga-api-7.3.0-dbgsym: usr-share-doc-symlink-to-foreign-package libsaga-api-7.3.0

These seem to be false positives, the dbgsym packages are generated from
the same source.

I think that binary_package_type should not return undef if the binary
package is a dbgsym package, e.g. something like:

 diff --git a/lib/Lintian/Collect/Source.pm b/lib/Lintian/Collect/Source.pm
 index 718a8f3e8..a3a597237 100644
 --- a/lib/Lintian/Collect/Source.pm
 +++ b/lib/Lintian/Collect/Source.pm
 @@ -338,7 +338,7 @@ sub binary_package_type {
  
     $self->{binaries} = \%binaries;
      return $binaries{$binary} if exists $binaries{$binary};
 -    return;
 +    return $binary =~ /-dbgym$/ ? 'deb' : undef;
  }
  
  =item source_field([FIELD[, DEFAULT]])

Kind Regards,

Bas