Comments regarding python-pdal_2.1.8+ds-2~exp1_amd64.changes

[Sebastiaan Couwenberg]

Hi Chris,

Thanks for the review.

On 7/14/19 3:59 PM, Chris Lamb wrote:
> Our hardworking trainees found the following issues in your package:
> 
> 	Can you confirm that libpdalpython.cpp can be regenerated using tools
> 	in the Debian archive?

Yes, it gets recreated from libpdalpython.pyx with cython as part of the
build. From my pbuilder log:

I: pybuild base:217: python3.7 setup.py config
Warning: passing language='c++' to cythonize() is deprecated. Instead,
put "# distutils: language=c++" in your .pyx or .pxd file(s)
Compiling pdal/libpdalpython.pyx because it depends on
/usr/lib/python3/dist-packages/Cython/Includes/numpy/__init__.pxd.
[1/1] Cythonizing pdal/libpdalpython.pyx
running config
/usr/lib/python3/dist-packages/Cython/Compiler/Main.py:367:
FutureWarning: Cython directive 'language_level' not set, using 2 for
now (Py2). This will change in a later release! File:
/build/python-pdal-2.1.8+ds/pdal/libpdalpython.pyx
  tree = Parsing.p_module(s, pxd, full_module_name)
   dh_auto_build -O--buildsystem=pybuild -O--parallel
I: pybuild base:217: /usr/bin/python3 setup.py build

> 	setup.py comes from the shapely project, which is BSD, but the
> 	copyright holder for that project should be given in d/copyright.

Added Sean C. Gillies for setup.py

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1