Bug#957773: savi: ftbfs with GCC-10

[Matthias Klose]

Package: src:savi
Version: 1.5.1-3
Severity: normal
Tags: sid bullseye
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-10

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-10/g++-10, but succeeds to build with gcc-9/g++-9. The
severity of this report will be raised before the bullseye release,
so nothing has to be done for the buster release.

The full build log can be found at:
http://people.debian.org/~doko/logs/gcc10-20200225/savi_1.5.1-3_unstable_gcc10.log
The last lines of the build log are at the end of this report.

To build with GCC 10, either set CC=gcc-10 CXX=g++-10 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-10/porting_to.html

[...]
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:126: multiple definition of `DIV6'; main.o:./src/./include/globals.h:126: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:129: multiple definition of `DEC6'; main.o:./src/./include/globals.h:129: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:126: multiple definition of `DIV7'; main.o:./src/./include/globals.h:126: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:129: multiple definition of `DEC7'; main.o:./src/./include/globals.h:129: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:126: multiple definition of `DIV8'; main.o:./src/./include/globals.h:126: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:129: multiple definition of `DEC8'; main.o:./src/./include/globals.h:129: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:126: multiple definition of `DIV9'; main.o:./src/./include/globals.h:126: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:129: multiple definition of `DEC9'; main.o:./src/./include/globals.h:129: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:127: multiple definition of `DIV10'; main.o:./src/./include/globals.h:127: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:130: multiple definition of `DEC10'; main.o:./src/./include/globals.h:130: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:127: multiple definition of `DIV11'; main.o:./src/./include/globals.h:127: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:130: multiple definition of `DEC11'; main.o:./src/./include/globals.h:130: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:127: multiple definition of `DIV12'; main.o:./src/./include/globals.h:127: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:130: multiple definition of `DEC12'; main.o:./src/./include/globals.h:130: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:127: multiple definition of `DIV13'; main.o:./src/./include/globals.h:127: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:130: multiple definition of `DEC13'; main.o:./src/./include/globals.h:130: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:127: multiple definition of `DIV14'; main.o:./src/./include/globals.h:127: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:130: multiple definition of `DEC14'; main.o:./src/./include/globals.h:130: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:127: multiple definition of `DIV15'; main.o:./src/./include/globals.h:127: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:130: multiple definition of `DEC15'; main.o:./src/./include/globals.h:130: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:127: multiple definition of `DIV16'; main.o:./src/./include/globals.h:127: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:130: multiple definition of `DEC16'; main.o:./src/./include/globals.h:130: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:127: multiple definition of `DIV17'; main.o:./src/./include/globals.h:127: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:130: multiple definition of `DEC17'; main.o:./src/./include/globals.h:130: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:127: multiple definition of `DIV18'; main.o:./src/./include/globals.h:127: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:130: multiple definition of `DEC18'; main.o:./src/./include/globals.h:130: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:127: multiple definition of `DIV19'; main.o:./src/./include/globals.h:127: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:130: multiple definition of `DEC19'; main.o:./src/./include/globals.h:130: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:59: multiple definition of `buttons_menu'; main.o:./src/./include/globals.h:59: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:94: multiple definition of `min_transmit_altitude'; main.o:./src/./include/globals.h:94: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:110: multiple definition of `parallels_angle'; main.o:./src/./include/globals.h:110: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:109: multiple definition of `equatorial_exclusion_angle'; main.o:./src/./include/globals.h:109: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:37: multiple definition of `geomview_module'; main.o:./src/./include/globals.h:37: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:116: multiple definition of `transforms_needed'; main.o:./src/./include/globals.h:116: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:114: multiple definition of `coverage_type'; main.o:./src/./include/globals.h:114: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:107: multiple definition of `single_step'; main.o:./src/./include/globals.h:107: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:106: multiple definition of `reset'; main.o:./src/./include/globals.h:106: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:105: multiple definition of `motion'; main.o:./src/./include/globals.h:105: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:103: multiple definition of `Version'; main.o:./src/./include/globals.h:103: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:95: multiple definition of `max_transmit_altitude'; main.o:./src/./include/globals.h:95: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:69: multiple definition of `orbit_model'; main.o:./src/./include/globals.h:69: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:55: multiple definition of `fisheye_viewpoint_flag'; main.o:./src/./include/globals.h:55: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:54: multiple definition of `sun_flag'; main.o:./src/./include/globals.h:54: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:53: multiple definition of `plane_flag'; main.o:./src/./include/globals.h:53: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:52: multiple definition of `footprints_flag'; main.o:./src/./include/globals.h:52: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:50: multiple definition of `geomview_sun_lighting'; main.o:./src/./include/globals.h:50: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:48: multiple definition of `geomview_compressed_images'; main.o:./src/./include/globals.h:48: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:46: multiple definition of `geomview_compress2_textures'; main.o:./src/./include/globals.h:46: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:45: multiple definition of `geomview_stream_textures'; main.o:./src/./include/globals.h:45: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:44: multiple definition of `geomview_texture_with_map'; main.o:./src/./include/globals.h:44: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:43: multiple definition of `geomview_dynamic_texture_flag'; main.o:./src/./include/globals.h:43: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:42: multiple definition of `geomview_detailed_texturemap'; main.o:./src/./include/globals.h:42: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:41: multiple definition of `texture_flag'; main.o:./src/./include/globals.h:41: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:39: multiple definition of `geomview_logo'; main.o:./src/./include/globals.h:39: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:38: multiple definition of `fake_geomview_module'; main.o:./src/./include/globals.h:38: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/globals.h:35: multiple definition of `command_switches'; main.o:./src/./include/globals.h:35: first defined here
/usr/bin/ld: tcl_utils.o:./src/./include/Satellite.h:70: multiple definition of `marker'; main.o:./src/./include/Satellite.h:70: first defined here
/usr/bin/ld: version.o:./src/version.c:1: multiple definition of `Version'; main.o:./src/./include/globals.h:103: first defined here
collect2: error: ld returned 1 exit status
make[4]: *** [Makefile:115: SaVi-ubuntu.bin] Error 1
make[4]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[3]: *** [Makefile:121: all] Error 2
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:18: all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j4 ARCH=ubuntu returned exit code 2
make[1]: *** [debian/rules:10: override_dh_auto_build] Error 25
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:7: build] Error 2
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2