[Git][debian-gis-team/postgis][master] Have the "postgis" package recommend "postgresql-postgis" instead of a specific version.

[Sebastiaan Couwenberg]

On 11/2/20 10:56 PM, Christoph Berg wrote:
> In passing, remove the extra NEWEST_PGVERSION logic in debian/control.in
> handling.
> =====================================
> debian/rules
> =====================================
> @@ -22,25 +22,7 @@ endif
>  
>  include /usr/share/dpkg/architecture.mk
>  include /usr/share/dpkg/pkg-info.mk
> -
> -# Magic to automatically create a debian/control file for the (or all)
> -# supported versions of Postgres.
> -#
> -# Blatantly copied from
> -# /usr/share/postgresql-common/pgxs_debian_control.mk and extended to
> -# support NEWEST_VERSION and fiddle with postgis 2.0 transitional
> -# packages.
> -debian/control: debian/control.in debian/pgversions
> -	(set -e; \
> -	VERSIONS=`pg_buildext supported-versions $(CURDIR)` || exit $$?; \
> -	NEWEST_VERSION=`pg_buildext supported-versions $(CURDIR) | tail -1` || exit $$?; \
> -	grep-dctrl -vP PGVERSION $< \
> -		| sed -e "s:NEWEST_PGVERSION:$$NEWEST_VERSION:" > $@.pgxs_tmp; \
> -	for v in $$VERSIONS; do \
> -		grep-dctrl -P PGVERSION $< \
> -			| sed -e "s:PGVERSION:$$v:" >> $@.pgxs_tmp; \
> -	done; \
> -	mv $@.pgxs_tmp $@) || (rm -f $@.pgxs_tmp; exit 1)
> +include /usr/share/postgresql-common/pgxs_debian_control.mk
>  
>  # Upstream version (including ~rcN) for symbols version
>  UPSTREAM_VERSION := $(shell echo $(DEB_VERSION_UPSTREAM) | sed -e 's/\+.*//')

Please don't do this, this makes building postgis on stable systems
impossible.

The clean target is executed outside the chroot where an older version
of postgresql will be installed (or none at all), the changes to the
control file will prevent git-buildpackage from starting the build.

Requiring the same version of postgresql to be installed outside the
chroot makes building postgresql related packages a pain in the ass.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1