[Git][debian-gis-team/libapache2-mod-tile][master] Completed changelog.

[Sebastiaan Couwenberg]

On 9/3/20 6:50 PM, Felix Delattre wrote:
> On 9/1/20 3:59 AM, Sebastiaan Couwenberg wrote:
>> On 8/31/20 10:18 PM, Felix Delattre wrote:
>>> By the way, it is coming together. It builds well on my side now.
>>
>> Did you use the lintian hook as documented in the policy?
> 
> Many thanks for all the support! I had the hook configured, but it wasn't working. After adjusting it, I fixed all errors, warnings and information messages. And addressed most of the pedantic and experimental messages.

You did not use dch to manage the changelog, hence it doesn't reflect
correctly who made which changes.

With the removal of the executables the paths in
debian/libapache2-mod-tile.install should be realigned. Same goes for
other install files.

The postinst probably shouldn't enable the munin plugins and leave that
up to the admin. If not, munin-node should be restarted to pick up the
new plugins, but that's not something a postinst should do.

Patches shouldn't have identical Origin & Forwarded headers. The Origin
header documents where the patch comes from, as it came from elsewhere.
If elsewhere is upstream, forwarding makes no sense. The Forwarded
header indicates that a patch added by a contributor to the packaging
was sent upstream.

Using /var/run for daemons is deprecated, and systemd complains about
that these days. Use /run instead.

Editing config files in maintainer scripts is fraught with danger. Have
you read the relevant policy section about that?

 https://www.debian.org/doc/debian-policy/ap-pkg-conffiles.html

Instead of adding shapefile binary files for the example map, using ogr
with OSM XML files would be better. We should no be encouraging the use
of shapefiles.

> From my perspective, I think we are coming very close, I would like to ask you, about how you would feel to submit this as experimental so it can face the NEW queue?

We're not quite there yet. The above is just what I noticed by looking
through the files under debian/, I haven't even built the package yet.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1