[Git][debian-gis-team/python-cartopy][master] 3 commits: Simplify the version file generation

[Sebastiaan Couwenberg]

On 12/4/21 19:30, Antonio Valentino (@antonio.valentino) wrote:
> =====================================
> debian/rules
> =====================================
> @@ -3,6 +3,8 @@
>   # Uncomment this to turn on verbose mode.
>   #export DH_VERBOSE = 1
>   
> +include /usr/share/dpkg/pkg-info.mk
> +
>   export DEB_BUILD_MAINT_OPTIONS = hardening=+all
>   
>   # Workaround for proj_api.h deprecation in PROJ 6.0.0
> @@ -29,8 +31,7 @@ override_dh_auto_clean:
>   	$(RM) -r __pycache__
>   
>   override_dh_auto_configure:
> -	python3 $(CURDIR)/debian/version.py
> -
> +	echo "version = '$(DEB_VERSION_UPSTREAM)'" > $(CURDIR)/lib/cartopy/_version.py
>   	dh_auto_configure
>   
>   override_dh_auto_test:

This is not equivalent to what version.py does, and is not better.

DEB_VERSION_UPSTREAM includes the repacksuffix which is not part of the 
upstream version that the Python code should use.

We strip that for symbols versions too, see for example:

 
https://salsa.debian.org/debian-gis-team/librttopo/-/blob/master/debian/rules#L10

Kind Regards,

Bas

-- 
  GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1