Bug#998624: python-deprecated: FTBFS with dh-python 5.20211105 due to missing dependencies

[Stefano Rivera]

Source: python-deprecated
Version: 1.2.13-1
Severity: serious
Tags: patch ftbfs
Justification: fails to build from source

dh-python 5.20211105 fixed tox detection based on Build-Depends, which
causes it to try to run tox tests on python-deprecated.
This fails because the tox.ini specifies dependencies that aren't met:

   dh_auto_test -O--buildsystem=pybuild
I: pybuild base:237: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9_deprecated/build; tox -c /<<PKGBUILDDIR>>/tox.ini --sitepackages -e py39
GLOB sdist-make: /<<PKGBUILDDIR>>/setup.py
py39 create: /<<PKGBUILDDIR>>/.tox/py39
py39 installdeps: PyTest, PyTest-Cov, coverage < 5
WARNING: Discarding $PYTHONPATH from environment, to override specify PYTHONPATH in 'passenv' in your configuration.
ERROR: invocation failed (exit code 1), logfile: /<<PKGBUILDDIR>>/.tox/py39/log/py39-1.log
================================== log start ===================================
Requirement already satisfied: PyTest in /usr/lib/python3/dist-packages (6.2.5)
Requirement already satisfied: PyTest-Cov in /usr/lib/python3/dist-packages (3.0.0)
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ProxyError('Cannot connect to proxy.', NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f5345d5b670>: Failed to establish a new connection: [Errno 111] Connection refused'))': /simple/coverage/
WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ProxyError('Cannot connect to proxy.', NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f5345d5b4c0>: Failed to establish a new connection: [Errno 111] Connection refused'))': /simple/coverage/
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ProxyError('Cannot connect to proxy.', NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f5345d5b820>: Failed to establish a new connection: [Errno 111] Connection refused'))': /simple/coverage/
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ProxyError('Cannot connect to proxy.', NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f5345d5be20>: Failed to establish a new connection: [Errno 111] Connection refused'))': /simple/coverage/
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ProxyError('Cannot connect to proxy.', NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f53458501f0>: Failed to establish a new connection: [Errno 111] Connection refused'))': /simple/coverage/
ERROR: Could not find a version that satisfies the requirement coverage<5
ERROR: No matching distribution found for coverage<5

=================================== log end ====================================
ERROR: could not install deps [PyTest, PyTest-Cov, coverage < 5]; v = InvocationError("/<<PKGBUILDDIR>>/.tox/py39/bin/python -m pip install PyTest PyTest-Cov 'coverage < 5'", 1)
___________________________________ summary ____________________________________
ERROR:   py39: could not install deps [PyTest, PyTest-Cov, coverage < 5]; v = InvocationError("/<<PKGBUILDDIR>>/.tox/py39/bin/python -m pip install PyTest PyTest-Cov 'coverage < 5'", 1)
E: pybuild pybuild:354: test: plugin distutils failed with: exit code=1: cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.9_deprecated/build; tox -c /<<PKGBUILDDIR>>/tox.ini --sitepackages -e py39
dh_auto_test: error: pybuild --test --test-tox -i python{version} -p 3.9 returned exit code 13
make: *** [debian/rules:10: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2


The easy solution here is to drop the tox Build-Depends (which exposes a
missing Build-Dep on setuptools):

diff -Nru python-deprecated-1.2.13/debian/control python-deprecated-1.2.13/debian/control
--- python-deprecated-1.2.13/debian/control	2021-08-15 04:07:04.000000000 -0700
+++ python-deprecated-1.2.13/debian/control	2021-11-05 01:03:31.000000000 -0700
@@ -8,9 +8,9 @@
                python3-all,
                python3-pytest,
                python3-pytest-cov,
+               python3-setuptools,
                python3-sphinx,
-               python3-wrapt,
-               tox
+               python3-wrapt
 Standards-Version: 4.5.1
 Vcs-Browser: https://salsa.debian.org/debian-gis-team/python-deprecated
 Vcs-Git: https://salsa.debian.org/debian-gis-team/python-deprecated.git

SR