tirex review

[Sebastiaan Couwenberg]

On 10/8/21 10:52 AM, Felix Delattre wrote:
> Thanks for your review(s)!
> 
> On 10/8/21 8:35 AM, Sebastiaan Couwenberg wrote:
>> dh_missing reports a lot of files that are installed but not included in
>> any package.
> 
> Yes, this is because we didn't include other backends than test and mapnik for now, as these others are almost not being used, and according to the maintainers, need a bit more work, in order confidently ship them to users.

If the build system installs files that are explicitly not included in
any package they should be removed in d/rules e.g.:

 https://salsa.debian.org/debian-gis-team/spatialite/-/blob/master/debian/rules#L61

Or added to debian/not-installed, see:

 https://manpages.debian.org/bullseye/debhelper/dh_missing.1.en.html#debian/not

>> The MAPNIK_PLUGIN_BASE templating is a little ugly, I've pushed a change
>> for an executable tirex.links.
> 
> Thanks. Will adjust a bit. And then it should be ready.

There is no need for adjusting tirex.links.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1