tilemaker review

[Sebastiaan Couwenberg]

On 9/3/21 9:02 PM, Felix Delattre wrote:
> On 9/3/21 9:30 AM, Sebastiaan Couwenberg wrote:
>>
>>    hardening-no-fortify-functions
>>    CPPFLAGS is not used.
> 
> Tried a lot around adding to debian/rules something like this:
> 
> ```
> CPPFLAGS:=$(shell dpkg-buildflags --get CPPFLAGS)
> CXXFLAGS := $(shell dpkg-buildflags --get CXXFLAGS) $(CPPFLAGS)
> export CXXFLAGS
> ```
> 
> but as far as I read with compat > 9 (which we are that should be handled already).
> 
> Do you have any suggestion or which package to look at on how it has been done?

Patch the Makefile to use ?= so that the flags set in the environment
are used if set (which they are thanks to dpkg-buildflags).

Or use += to append the flags from the Makefile to those set in the
environment. dpkg-buildflags uses -O2 which may be preferable to -O3 set
in the makefile.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1