tilemaker review

[Sebastiaan Couwenberg]

On 9/8/21 11:45 PM, Felix Delattre wrote:
> Thanks for all the great input. This was very useful - both the patch and the explanations around the *FLAGS environment variables.
> I addressed the points you mentioned with the last commits.

CPPFLAGS still isn't used. Patching the Makefile to turn

  $(CXX) $(CXXFLAGS) -o ...

into

  $(CXX) $(CXXFLAGS) $(CPPFLAGS) -o ...

Should resolve that.

Instead of using a patch for -pthread use:

 export DEB_LDFLAGS_MAINT_APPEND=-pthread

in debian/rules instead. See dpkg-buildflags(1).

The upstream Makefile shouldn't use := for *FLAGS to allow the user to
set additional flags in the environment. The CMake buildsystem might be
a better option than a handcrafted Makefile not using autotools.

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1