tirex review

[Sebastiaan Couwenberg]

On 9/11/21 12:08 PM, Felix Delattre wrote:
> On 9/11/21 8:40 AM, Sebastiaan Couwenberg wrote:
>> The mapnik-plugin-base variable is not defined though.
> 
> Are you sure? It works on my side. The `mapnik-plugin-base` is a command provided by the build dependency `mapnik-dev`.

I missed that, I read it as a Makefile variable not a subshell command.

>> If you create the directory and symlink via tirex.dirs & tirex.links you
>> don't need to remove the directory in the maintainer script and leave it
>> to dpkg to remove them.
> 
> What is the proper way to set the symlink via tirex.links when I want to call `mapnik-plugin-base` for the flexible part? I currently do this in the postinst file.

Add tirex.links.in and use that template to create tirex.links, see
grass for example:

 https://salsa.debian.org/debian-gis-team/grass/-/blob/master/debian/rules#L45

Alternatively turn tirex.links into a script. libmapscript-perl uses
this to get the vendorarch path from the installer perl version:

 https://salsa.debian.org/debian-gis-team/mapserver/-/blob/master/debian/libmapscript-perl.install

 https://manpages.debian.org/bullseye/debhelper/debhelper.7.en.html#Executable_debhelper_config_files

Kind Regards,

Bas

-- 
 GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146  50D1 6750 F10A E88D 4AF1