Bug#1010002: libgeos++-dev: Missing files or misconfigured build

[Pierre Gergondet]

Package: libgeos++-dev
Version: 3.10.2-1
Severity: grave
Justification: renders package unusable
X-Debbugs-Cc: pierre.gergondet at gmail.com

Dear Maintainer,

libgeos++-dev is missing .inl files required to build programs with the
C++ interface.

When GEOS is built, the GEOS_INLINE macro is defined. If the package is
find and linked through CMake, this macro is defined as well. However,
building with this macro triggers the inclusion of .inl files which are
explicitly removed by the `rules` file of this package, therefore the
build file.

Looking through the package build history, it seems the GEOS_INLINE definition
has been used for a long time but was not necessary to link against the
library.

For example, compling the following program (main.cpp):

```
#include <geos/geom/Coordinate.h>

int main()
{
  geos::geom::Coordinate c;
  c.setNull();
  return 0;
}
```

Fails to compile with `g++ -o main main.cpp -lgeos` (but this works on
e.g. Debian stable)

On the other hand, adding `-DGEOS_INLINE` also fails because the .inl
files are not shipped with the package.

I think this can be fixed by either:
- removing the explicit removal of .inl files from the `rules` file
- passing `-DDISABLE_GEOS_INLINE:BOOL=ON` during the configuration

The second solution might be less disruptive as this won't require
existing builds to pass `-DGEOS_INLINE` if they are not relying on CMake
to find the correct compilation flags.

-- System Information:
Debian Release: bookworm/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.4.0-107-generic (SMP w/16 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: unable to detect

Versions of packages libgeos++-dev depends on:
ii  libgeos-dev    3.10.2-1
ii  libgeos3.10.2  3.10.2-1

libgeos++-dev recommends no packages.

Versions of packages libgeos++-dev suggests:
pn  libgdal-doc  <none>

-- no debconf information