Bug#1046070: php-geos: Fails to build source after successful build

[Lucas Nussbaum]

Source: php-geos
Version: 1.0.0-7
Severity: minor
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-sab-20230813 ftbfs-source-after-build
User: debian-qa at lists.debian.org
Usertags: qa-doublebuild

Hi,

This package fails to build a source package after a successful build
(dpkg-buildpackage ; dpkg-buildpackage -S).

This is probably a clear violation of Debian Policy section 4.9 (clean target),
but this is filed as severity:minor for now, because a discussion on
debian-devel showed that we might want to revisit the requirement of a working
'clean' target.

More information about this class of issues, included common problems and
solutions, is available at
https://wiki.debian.org/qa.debian.org/FTBFS/SourceAfterBuild

Relevant part of the build log:
> cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S
> -----------------------------------------------------------------------------------------------------------------------
> 
> dpkg-buildpackage: info: source package php-geos
> dpkg-buildpackage: info: source version 1.0.0-7
> dpkg-buildpackage: info: source distribution unstable
> dpkg-buildpackage: info: source changed by Bas Couwenberg <sebastic at debian.org>
>  dpkg-source --before-build .
>  debian/rules clean
> dh clean --with php
>    dh_auto_clean
> 	make -j8 distclean
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> find . -name \*.gcno -o -name \*.gcda | xargs rm -f
> find . -name \*.lo -o -name \*.o -o -name \*.dep | xargs rm -f
> find . -name \*.la -o -name \*.a | xargs rm -f
> find . -name \*.so | xargs rm -f
> find . -name .libs -a -type d|xargs rm -rf
> rm -f libphp.la      modules/* libs/*
> rm -f ext/opcache/jit/zend_jit_x86.c
> rm -f ext/opcache/jit/zend_jit_arm64.c
> rm -f ext/opcache/minilua
> rm -f Makefile config.cache config.log config.status Makefile.objects Makefile.fragments libtool main/php_config.h main/internal_functions_cli.c main/internal_functions.c Zend/zend_dtrace_gen.h Zend/zend_dtrace_gen.h.bak Zend/zend_config.h
> rm -f main/build-defs.h scripts/phpize
> rm -f ext/date/lib/timelib_config.h ext/mbstring/libmbfl/config.h ext/oci8/oci8_dtrace_gen.h ext/oci8/oci8_dtrace_gen.h.bak
> rm -f scripts/man1/phpize.1 scripts/php-config scripts/man1/php-config.1 sapi/cli/php.1 sapi/cgi/php-cgi.1 sapi/phpdbg/phpdbg.1 ext/phar/phar.1 ext/phar/phar.phar.1
> rm -f sapi/fpm/php-fpm.conf sapi/fpm/init.d.php-fpm sapi/fpm/php-fpm.service sapi/fpm/php-fpm.8 sapi/fpm/status.html
> rm -f ext/phar/phar.phar ext/phar/phar.php
> if test "/<<PKGBUILDDIR>>" != "/<<PKGBUILDDIR>>"; then \
>   rm -f ext/phar/phar/phar.inc; \
> fi
> /bin/grep -E define'.*include/php' /<<PKGBUILDDIR>>/configure | /bin/sed 's/.*>//'|xargs rm -f
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
>    dh_autoreconf_clean
>    dh_clean
>  dpkg-source -b .
> dpkg-source: info: using source format '3.0 (quilt)'
> dpkg-source: info: building php-geos using existing ./php-geos_1.0.0.orig.tar.gz
> dpkg-source: info: using patch list from debian/patches/series
> dpkg-source: warning: executable mode 0755 of 'config.nice' will not be represented in diff
> dpkg-source: info: local changes detected, the modified files are:
>  php-geos-1.0.0/config.h
>  php-geos-1.0.0/config.nice
> dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/php-geos_1.0.0-7.diff.8biq0z
> dpkg-source: info: Hint: make sure the version in debian/changelog matches the unpacked source tree
> dpkg-source: info: you can integrate the local changes with dpkg-source --commit
> dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
> 
> E: Command 'cd /<<PKGBUILDDIR>> && runuser -u user42 -- dpkg-buildpackage --sanitize-env -us -uc -rfakeroot -S' failed to run.


The full build log is available from:
http://qa-logs.debian.net/2023/08/13/php-geos_1.0.0-7_unstable.log

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.