Bug#1075309: ncview: ftbfs with GCC-14

[Matthias Klose]

Package: src:ncview
Version: 2.1.8+ds-5
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/ncview_2.1.8+ds-5_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
      |                                    ~~~~~~~~~~~~~~~~~
view.c: In function ‘draw_file_info’:
view.c:2011:57: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 253 [-Wformat-truncation=]
 2011 |                         snprintf( temp_label, 255, "%s (%s)", limit_string(view->variable->name),
      |                                                         ^~
 2012 |                                                                 range_label );
      |                                                                 ~~~~~~~~~~~
In function ‘snprintf’,
    inlined from ‘draw_file_info’ at view.c:2011:4:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: ‘__builtin___snprintf_chk’ output 4 or more bytes (assuming 259) into a destination of size 255
   54 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   55 |                                    __glibc_objsize (__s), __fmt,
      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   56 |                                    __va_arg_pack ());
      |                                    ~~~~~~~~~~~~~~~~~
interface/filesel.c: In function ‘fs_double_click’:
interface/filesel.c:244:25: error: passing argument 2 of ‘XawListChange’ from incompatible pointer type [-Wincompatible-pointer-types]
  244 |                         stringlist_to_Xawlist( files_and_dirs ),
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                         |
      |                         char **
In file included from interface/../ncview.includes.h:59,
                 from interface/filesel.c:30:
/usr/include/X11/Xaw/List.h:170:27: note: expected ‘const char **’ but argument is of type ‘char **’
  170 |  _Xconst char           **list,
      |                           ^
make[3]: *** [Makefile:539: interface/filesel.o] Error 1
make[3]: *** Waiting for unfinished jobs....
view.c: In function ‘view_report_position’:
view.c:2229:77: warning: ‘%s’ directive output may be truncated writing up to 79 bytes into a region of size between 4 and 54 [-Wformat-truncation=]
 2229 |         snprintf( current_value_label, 79, "Current: (i=%1ld, j=%1ld) %g (x=%s, y=%s)\n",
      |                                                                             ^~
 2230 |                                 data_x, data_y, val, xdim_str, ydim_str );
      |                                                      ~~~~~~~~                
In function ‘snprintf’,
    inlined from ‘view_report_position’ at view.c:2229:2:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: ‘__builtin___snprintf_chk’ output between 32 and 240 bytes into a destination of size 79
   54 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   55 |                                    __glibc_objsize (__s), __fmt,
      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   56 |                                    __va_arg_pack ());
      |                                    ~~~~~~~~~~~~~~~~~
view.c: In function ‘view_report_position_vals’:
view.c:2326:64: warning: ‘%s’ directive output may be truncated writing up to 79 bytes into a region of size 68 [-Wformat-truncation=]
 2326 |                 snprintf( current_value_label, 79, "Current: x=%s, y=%g",
      |                                                                ^~
 2327 |                                 temp, yval );
      |                                 ~~~~                            
view.c:2326:52: note: assuming directive output of 12 bytes
 2326 |                 snprintf( current_value_label, 79, "Current: x=%s, y=%g",
      |                                                    ^~~~~~~~~~~~~~~~~~~~~
In function ‘snprintf’,
    inlined from ‘view_report_position_vals’ at view.c:2326:3:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:54:10: note: ‘__builtin___snprintf_chk’ output between 17 and 108 bytes into a destination of size 79
   54 |   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   55 |                                    __glibc_objsize (__s), __fmt,
      |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   56 |                                    __va_arg_pack ());
      |                                    ~~~~~~~~~~~~~~~~~
make[3]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[2]: *** [Makefile:386: all-recursive] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>'
make[1]: *** [Makefile:327: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:11: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2