Bug#1077357: fiona: FTBFS: fiona/_env.c:4255:32: error: passing argument 1 of ‘CSLAddString’ from incompatible pointer type [-Wincompatible-pointer-types]

[Lucas Nussbaum]

Source: fiona
Version: 1.9.6-1
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240727 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> INFO:root:x86_64-linux-gnu-gcc -fno-strict-overflow -Wsign-compare -DNDEBUG -g -O2 -Wall -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wdate-time -D_FORTIFY_SOURCE=2 -fPIC -I/usr/include/gdal -I/usr/include/python3.12 -c fiona/_env.c -o build/temp.linux-x86_64-cpython-312/fiona/_env.o
> fiona/_env.c: In function ‘__pyx_f_5fiona_4_env_set_proj_search_path’:
> fiona/_env.c:4255:32: error: passing argument 1 of ‘CSLAddString’ from incompatible pointer type [-Wincompatible-pointer-types]
>  4255 |   __pyx_v_paths = CSLAddString(__pyx_v_paths, __pyx_v_path_c);
>       |                                ^~~~~~~~~~~~~
>       |                                |
>       |                                const char **
> In file included from fiona/_env.c:1260:
> /usr/include/gdal/cpl_string.h:65:36: note: expected ‘char **’ but argument is of type ‘const char **’
>    65 | char CPL_DLL **CSLAddString(char **papszStrList,
>       |                             ~~~~~~~^~~~~~~~~~~~
> fiona/_env.c:4255:17: error: assignment to ‘const char **’ from incompatible pointer type ‘char **’ [-Wincompatible-pointer-types]
>  4255 |   __pyx_v_paths = CSLAddString(__pyx_v_paths, __pyx_v_path_c);
>       |                 ^
> error: command '/usr/bin/x86_64-linux-gnu-gcc' failed with exit code 1
> 
> ERROR Backend subprocess exited when trying to invoke build_wheel
> E: pybuild pybuild:389: build: plugin pyproject failed with: exit code=1: python3.12 -m build --skip-dependency-check --no-isolation --wheel --outdir /<<PKGBUILDDIR>>/.pybuild/cpython3_3.12_fiona  
> dh_auto_build: error: pybuild --build -i python{version} -p 3.12 returned exit code 13
> make: *** [debian/rules:44: binary] Error 25


The full build log is available from:
http://qa-logs.debian.net/2024/07/27/fiona_1.9.6-1_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240727;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240727&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.