[Git][debian-gis-team/python-s3fs] Pushed new branch master

[Antonio Valentino]

Dear Bas,
thanks a lot for reviewing the package.

Il 14/12/25 21:01, Sebastiaan Couwenberg ha scritto:
> debian/control:
> 
>   python3-aiobotocore (>=2.25.2),
>   python3-aiobotocore (<<2.26.0),
> 
> These version constraints are problematic, 2.13.1 is in unstable and RC- 
> buggy for almost a year: #1091485
> 
> You'll have to help the maintainer get that package into shape.
> 
> requirements.txt is much less strict:
> 
>   aiobotocore>=2.5.4,<3.0.0

Unfortunately, the current version of s3fs is not compatible with 
aiobotocore 2.13.1: import failures.
It is not even compatible with the latest version of the 2.x series 
(2.26) for the same reason, but with v2.25.x it is working.

I run the the test suite locally to be sure that everything works as 
expected.

I didn't check older versions because I have already opened a merge 
request [1] to update aiobotocore to v2.15.2 and fix #1091485.

I have also contacted the aiobotocore maintained via [2].

We need to wait for the aiobotocore update before being able to upload 
python-s3fs.

[1] 
https://salsa.debian.org/homeassistant-team/deps/python-aiobotocore/-/merge_requests/1 

[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1091485#12

> debian/copyright:
> 
> public-domain license is special:
> 
> "
>   When the License field in a stanza has the short name public-domain, 
> the remaining lines of the field must explain exactly what exemption the 
> corresponding files for that stanza have from default copyright 
> restrictions.
> "
> 
> https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/ 
> #public-domain

Not sure to understand what to do from a practical point of view.

The versioneeer.py file contains some text regarding the licensing:

```
## License

To make Versioneer easier to embed, all its code is dedicated to the public
domain. The `_version.py` that it creates is also in the public domain.
Specifically, both are released under the "Unlicense", as described in
https://unlicense.org/.

```

What I have reported in the d/copyright file is the same text used for 
the python-versioneer debian package [3].

[3] 
https://tracker.debian.org/media/packages/p/python-versioneer/copyright-0.29-1.

Actually I could patch the package to use the debian packaged version of 
versioneer instead of the embedded one but it looked to me a little bit 
an overkill.
What do you suggest?


> Don't use a standalone license paragraph for these sections.
> 
> 
> debian/gitlab-ci.yml:
> 
> Needs to renamed to .gitlab-ci.yml as configured in Salsa for all our 
> repos.
> 

ok

> 
> debian/rules:
> 
> Please add an empy line before the %: target.
done

> Also consider exporting PYBUILD_TEST_ARGS=-vv.

Unfortunately almost all the unittest for the s3fs package require 
access to the interned so I simply decided to not activate any 
unittesting for this package.


> I've pushed changes for d/control & d/.gitlab-ci.yml.

thanks


regards
-- 
Antonio Valentino