Bug#1134166: jeolib-jiplib: FTBFS with GDAL 3.13.0

[Bas Couwenberg]

Source: jeolib-jiplib
Version: 1.1.7+ds-1
Severity: important
Tags: upstream ftbfs patch
User: debian-gis at lists.debian.org
Usertags: gdal-3.13

Dear Maintainer,

Your package FTBFS with GDAL 3.13.0:

 error: invalid conversion from 'CSLConstList' {aka 'const char* const*'} to 'char**' [-fpermissive]

>From GDAL 3.13.0 NEWS:

 * GDALMajorObject: Use CSLConstList for GetMetadata, SetMetadata (API breakage)

https://github.com/OSGeo/gdal/blob/v3.13.0beta1/NEWS.md

The attached patch fixes the issue.

Kind Regards,

Bas
-------------- next part --------------
diff -Nru jeolib-jiplib-1.1.7+ds/debian/changelog jeolib-jiplib-1.1.7+ds/debian/changelog
--- jeolib-jiplib-1.1.7+ds/debian/changelog	2026-02-09 13:45:52.000000000 +0100
+++ jeolib-jiplib-1.1.7+ds/debian/changelog	2026-04-17 10:26:54.000000000 +0200
@@ -1,3 +1,9 @@
+jeolib-jiplib (1.1.7+ds-2) UNRELEASED; urgency=medium
+
+  * Rebuild with GDAL 3.13.0.
+
+ -- Bas Couwenberg <sebastic at debian.org>  Fri, 17 Apr 2026 10:26:54 +0200
+
 jeolib-jiplib (1.1.7+ds-1) unstable; urgency=medium
 
   * Team upload.
diff -Nru jeolib-jiplib-1.1.7+ds/debian/patches/gdal-3.13.patch jeolib-jiplib-1.1.7+ds/debian/patches/gdal-3.13.patch
--- jeolib-jiplib-1.1.7+ds/debian/patches/gdal-3.13.patch	1970-01-01 01:00:00.000000000 +0100
+++ jeolib-jiplib-1.1.7+ds/debian/patches/gdal-3.13.patch	2026-04-17 10:26:54.000000000 +0200
@@ -0,0 +1,64 @@
+--- a/src/imageclasses/Jim.cc
++++ b/src/imageclasses/Jim.cc
+@@ -1026,7 +1026,11 @@ void Jim::getGeoTransform(vector<double>
+ /**
+  * @return the metadata of this data set in C style string format (const version)
+  **/
++#if GDAL_VERSION_NUM >= GDAL_COMPUTE_VERSION(3, 13, 0)
++CSLConstList Jim::getMetadata() const
++#else
+ char** Jim::getMetadata() const
++#endif
+ {
+   if(m_gds){
+     if(m_gds->GetMetadata()!=NULL)
+@@ -1045,7 +1049,11 @@ char** Jim::getMetadata() const
+ void Jim::getMetadata(std::list<std::string>& metadata) const
+ {
+   if(m_gds){
++#if GDAL_VERSION_NUM >= GDAL_COMPUTE_VERSION(3, 13, 0)
++    CSLConstList cmetadata=m_gds->GetMetadata();
++#else
+     char** cmetadata=m_gds->GetMetadata();
++#endif
+     while(*cmetadata!=NULL){
+       metadata.push_back(*(cmetadata));
+       ++cmetadata;
+@@ -1494,7 +1502,11 @@ CPLErr Jim::registerDriver()
+       s << "FileOpenError (" << m_imageType << ")";
+       throw(s.str());
+     }
++#if GDAL_VERSION_NUM >= GDAL_COMPUTE_VERSION(3, 13, 0)
++    CSLConstList papszMetadata;
++#else
+     char **papszMetadata;
++#endif
+     papszMetadata = poDriver->GetMetadata();
+     //todo: try and catch if CREATE is not supported (as in PNG)
+     if( ! CSLFetchBoolean( papszMetadata, GDAL_DCAP_CREATE, FALSE )){
+@@ -2120,7 +2132,11 @@ CPLErr Jim::open(app::AppFactory &app){
+     GDALRasterBand *poBand;//we will fetch the first band to obtain the gds metadata
+ 
+     if(m_gds){
++#if GDAL_VERSION_NUM >= GDAL_COMPUTE_VERSION(3, 13, 0)
++      CSLConstList papszMetadata;
++#else
+       char **papszMetadata;
++#endif
+       papszMetadata = m_gds->GetMetadata("SUBDATASETS");
+       vector<string> LayersAll;
+       if( papszMetadata ){
+--- a/src/imageclasses/Jim.h
++++ b/src/imageclasses/Jim.h
+@@ -640,7 +640,11 @@ class Jim : public std::enable_shared_fr
+   //Get a pointer to the GDAL dataset
+   GDALDataset* getDataset(){return m_gds;};
+   ///Get the metadata of this dataset
++#if GDAL_VERSION_NUM >= GDAL_COMPUTE_VERSION(3, 13, 0)
++  CSLConstList getMetadata() const;
++#else
+   char** getMetadata() const;
++#endif
+   // Get the metadata of this dataset in the form of a list of strings (const version)
+   void getMetadata(std::list<std::string>& metadata) const;
+   ///Get the image description from the driver of this dataset
diff -Nru jeolib-jiplib-1.1.7+ds/debian/patches/series jeolib-jiplib-1.1.7+ds/debian/patches/series
--- jeolib-jiplib-1.1.7+ds/debian/patches/series	2026-02-09 13:44:35.000000000 +0100
+++ jeolib-jiplib-1.1.7+ds/debian/patches/series	2026-04-17 10:26:54.000000000 +0200
@@ -1,2 +1,3 @@
 pip-break-sys-pkg.patch
 wheel.patch
+gdal-3.13.patch