[jason@debian.org: Re: Bug#264506: all fine, but grub]

[Robert Millan]

Hey.

Martin told me that the patch doesn't work for him.  This is somewhat weird,
since the person who submitted it seemed to be quite reliable (an ibm
employee) and claimed to have tested it.

Peter, you gave to understand that you had the same problem with ext3.  Is
that it?  Please, could you try the patch?

On Sun, Aug 15, 2004 at 11:52:32PM +0100, Martin Michlmayr wrote:
> ----- Forwarded message from Jason Thomas <jason@debian.org> -----
> 
> From: Jason Thomas <jason@debian.org>
> Subject: Re: Bug#264506: all fine, but grub
> Date: Thu, 12 Aug 2004 09:59:03 +1000
> To: Martin Michlmayr <tbm@cyrius.com>
> User-Agent: Mutt/1.5.6+20040803i
> 
> You can try this patch or wait for grub to be updated. Let me know if it works.
> 
> ===================================================================
> RCS file: /cvsroot/grub/cvsroot/grub/grub/stage2/fsys_ext2fs.c,v
> retrieving revision 1.13
> retrieving revision 1.14
> diff -u -r1.13 -r1.14
> --- grub/grub/stage2/fsys_ext2fs.c	2003/12/30 12:36:13	1.13
> +++ grub/grub/stage2/fsys_ext2fs.c	2004/08/07 06:48:58	1.14
> @@ -432,12 +432,16 @@
>        if (size > len)
>  	size = len;
>  
> -      disk_read_func = disk_read_hook;
> +      if (map == 0) {
> +        memset ((char *) buf, 0, size);
> +      } else {
> +        disk_read_func = disk_read_hook;
>  
> -      devread (map * (EXT2_BLOCK_SIZE (SUPERBLOCK) / DEV_BSIZE),
> -	       offset, size, buf);
> +        devread (map * (EXT2_BLOCK_SIZE (SUPERBLOCK) / DEV_BSIZE),
> +	         offset, size, buf);
>  
> -      disk_read_func = NULL;
> +        disk_read_func = NULL;
> +      }
>  
>        buf += size;
>        len -= size;
> 
> 
> On Thu, Aug 12, 2004 at 12:37:52AM +0100, Martin Michlmayr wrote:
> > * Jason Thomas <jason@debian.org> [2004-08-12 09:33]:
> > > What filesystem? A new patch for sparse files on ext2/3 just went into
> > > grub.
> > 
> > I used ext3.
> > 
> > -- 
> > Martin Michlmayr
> > tbm@cyrius.com
> > 
> > Scanned by PeNiCillin http://safe-t-net.pnc.com.au/
> 
> -- 
> Jason
> 
> "I hope you learn speaking English proper I hope speak I me you."
>      -- Branden Robinson, 2001
> 
> ----- End forwarded message -----
> 
> -- 
> Martin Michlmayr
> tbm@cyrius.com

-- 
Robert Millan

(Debra and Ian) (Gnu's Not (UNiplexed Information and Computing System))/\
(kernel of *(Berkeley Software Distribution))