Bug#235017: marked as done (grubconf_0.5-1(unstable/sparc): missing build-depends and bad Architecture: line)
Debian Bug Tracking System
owner@bugs.debian.org
Wed, 24 Mar 2004 11:48:06 -0800
Your message dated Wed, 24 Mar 2004 14:44:11 -0500
with message-id <20040324194411.GD27585@ruslug.rutgers.edu>
and subject line Bug#235017, Bug#236356, New Debian grubconf-0.5.1-1
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 27 Feb 2004 00:54:38 +0000
>From james@ruari-quinn.demon.co.uk Thu Feb 26 16:54:38 2004
Return-path: <james@ruari-quinn.demon.co.uk>
Received: from cpc1-leed3-6-0-cust171.ldst.cable.ntl.com (shiri.gloaming.local) [80.6.171.171] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1AwWH0-0000ab-00; Thu, 26 Feb 2004 16:54:38 -0800
Received: from james by shiri.gloaming.local with local (Exim 3.36 #1 (Debian))
id 1AwWGz-0001Pb-00
for <submit@bugs.debian.org>; Fri, 27 Feb 2004 00:54:37 +0000
To: submit@bugs.debian.org
Subject: grubconf_0.5-1(unstable/sparc): missing build-depends and bad
Architecture: line
Mail-Copies-To: never
From: James Troup <james@nocrew.org>
Date: Fri, 27 Feb 2004 00:54:37 +0000
Message-ID: <87wu691gvm.fsf@shiri.gloaming.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: James Troup <james@ruari-quinn.demon.co.uk>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_02_22
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=HAS_PACKAGE autolearn=no
version=2.60-bugs.debian.org_2004_02_22
X-Spam-Level:
Package: grubconf
Version: 0.5-1
Severity: serious
You appear to be missing a build-depends on scrollkeeper.
Also, since you Depend on grub, you need to limit your architecture
field to those that grub supports otherwise your package will never
get into testing.
| Automatic build of grubconf_0.5-1 on vore by sbuild/sparc 1.170.4
| Build started at 20040223-1715
| ******************************************************************************
[...]
| ** Using build dependencies supplied by package:
| Build-Depends: debhelper (>= 4.0.0), gcc (>= 4:3.2), libgnomeui-dev (>= 2.4.0.1-6), autoconf, automake1.4
[...]
| checking for scrollkeeper-config... no
| configure: error: Couldn't find scrollkeeper-config. Please install the scrollkeeper package
| make: *** [config.status] Error 1
A complete build log can be found at
http://buildd.debian.org/build.php?arch=sparc&pkg=grubconf&ver=0.5-1
--
James
---------------------------------------
Received: (at 235017-done) by bugs.debian.org; 24 Mar 2004 19:44:13 +0000
>From mcgrof@studorgs.rutgers.edu Wed Mar 24 11:44:13 2004
Return-path: <mcgrof@studorgs.rutgers.edu>
Received: from studorgs.rutgers.edu (ruslug.rutgers.edu) [128.6.24.131]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1B6EIO-0000xH-00; Wed, 24 Mar 2004 11:44:12 -0800
Received: by ruslug.rutgers.edu (Postfix, from userid 503)
id 07A3EF9D4B; Wed, 24 Mar 2004 14:44:11 -0500 (EST)
Date: Wed, 24 Mar 2004 14:44:11 -0500
To: pkg-grub-devel@lists.alioth.debian.org,
grubconf-general@lists.sourceforge.net, 235017-done@bugs.debian.org,
236356@bugs.debian.org,
Joseph Monti <countjoe@users.sourceforge.net>,
Ryan Scotka <evangelionrs@users.sourceforge.net>
Cc: Robert Millan <zeratul2@wanadoo.es>,
Andreas Rottmann <a.rottmann@gmx.at>, James Troup <james@nocrew.org>,
Didier Conchaudron <conchaudron@free.fr>
Subject: Bug#235017, Bug#236356, New Debian grubconf-0.5.1-1
Message-ID: <20040324194411.GD27585@ruslug.rutgers.edu>
Reply-To: Grub-Devel List <pkg-grub-devel@lists.alioth.debian.org>,
Grubconf General List <grubconf-general@lists.sourceforge.net>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="jousvV0MzM2p6OtC"
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
X-Operating-System: 2.4.18-1-686
Organization: Rutgers University Student Linux Users Group
From: mcgrof@ruslug.rutgers.edu (Luis R. Rodriguez)
Delivered-To: 235017-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_12
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-2.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2004_03_12
X-Spam-Level:
--jousvV0MzM2p6OtC
Content-Type: multipart/mixed; boundary="rJwd6BRFiFCcLxzm"
Content-Disposition: inline
--rJwd6BRFiFCcLxzm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
So I've released a new grubconf deb.
This fixes Bug#235017, and I was unable to reproduce Bug#236356.
Grubconf.sf.net had a new grubconf upstream release, 0.5.1 so I've used
that. This source had some noticeable bugs so I've fixed them for our deb r=
elease.
I'm still a debian developer in review so I do not yet have upload
privileges. I believe Robert Millan last uploaded my latest grubconf
release. This needs to be uploaded as well. Please find complete deb
sources/deb here:
http://ruslug.rutgers.edu/~mcgrof/grubconf/
Upstream authors (Joseph Monti and Ryan Scotka):
Please see attached patches, they fix:
* debian/patches/fix-dir_attempt.diff: Fixes upstream source for when=20
filename specified is a directory
* debian/patches/fix-makeinstall.diff: Fixes upstream source for make
install on debian testing/unstable
* debian/patches/fix-verbose.diff: Fixes upstream source with verbose mes=
sage
when non-supported grub command is encountered.
Here is the deb changelog:
grubconf (0.5.1-1) unstable; urgency=3Dlow
* new grubconf release: 0.5.1
* debian/control: added scrollkeeper to Build-Depends. Fixes=20
(closes: #235017)
* debian/control: added "i386 hurd-i386 freebsd-i386 netbsd-i386"
to Architecture field. These match the archs for which grub
is available.
* Unable to reproduce bug #236356.
* removed /usr/include/grubconf/* -- unwanted
* debian/control: Added Grub-Devel List <pkg-grub-devel@lists.alioth.debi=
an.org>
as Maintainer, added myself as Uploader
* debian/rules: moved to new cdbs format
* debian/control: fixed format, removed double spaces and such
* debian/patches/fix-dir_attempt.diff: Fixes upstream source for when=20
filename specified is a directory
* debian/patches/fix-makeinstall.diff: Fixes upstream source for make
install on debian testing/unstable
* debian/patches/fix-verbose.diff: Fixes upstream source with verbose mes=
sage
when non-supported grub command is encountered.
=20
I will be going on vacation later today for 5 days. If anyone needs
anything I trust pkg-grub-devel team to do the appropriate changes.
Thanks,
Luis
--=20
GnuPG Key fingerprint =3D 113F B290 C6D2 0251 4D84 A34A 6ADD 4937 E20A 525E
--rJwd6BRFiFCcLxzm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="fix-dir_attempt.diff"
Content-Transfer-Encoding: quoted-printable
diff -Naur grubconf-0.5.1/src/main.c grubconf-0.5.1-mcgrof/src/main.c
--- grubconf-0.5.1/src/main.c 2003-04-17 09:33:00.000000000 -0400
+++ grubconf-0.5.1-mcgrof/src/main.c 2004-03-24 02:53:24.000000000 -0500
@@ -22,6 +22,9 @@
* The main entry point.
*/
=20
+#include <sys/types.h>
+#include <dirent.h>
+
#include <gnome.h>
#include <gconf/gconf-client.h>
#include <fcntl.h>
@@ -132,6 +135,12 @@
grubconf_fname =3D cwd;
}
=20
+ if (opendir(grubconf_fname) !=3D NULL) {
+ gtk_message (GTK_MESSAGE_ERROR, _(
+ "File passed is a directory, not a file!"));
+ return -1;
+ }
+
if (create_fname) {
// attempt to create a file
int fd =3D open (grubconf_fname, O_WRONLY | O_CREAT);
--rJwd6BRFiFCcLxzm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="fix-makeinstall.diff"
Content-Transfer-Encoding: quoted-printable
diff -Naur grubconf-0.5.1/po/Makefile.in.in grubconf-0.5.1-mcgrof/po/Makefi=
le.in.in
--- grubconf-0.5.1/po/Makefile.in.in 2003-01-13 14:42:38.000000000 -0500
+++ grubconf-0.5.1-mcgrof/po/Makefile.in.in 2004-03-24 02:03:26.000000000 -=
0500
@@ -29,7 +29,7 @@
INSTALL =3D @INSTALL@
INSTALL_DATA =3D @INSTALL_DATA@
MKINSTALLDIRS =3D @MKINSTALLDIRS@
-mkinstalldirs =3D $(SHELL) `case "$(MKINSTALLDIRS)" in /*) echo "$(MKINSTA=
LLDIRS)" ;; *) echo "$(top_builddir)/$(MKINSTALLDIRS)" ;; esac`
+mkinstalldirs =3D $(SHELL) `case "$(MKINSTALLDIRS)" in /*) echo "$(MKINSTA=
LLDIRS)" ;; *) echo "$(MKINSTALLDIRS)" ;; esac`
=20
CC =3D @CC@
GMSGFMT =3D @GMSGFMT@
--rJwd6BRFiFCcLxzm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="fix-verbose.diff"
Content-Transfer-Encoding: quoted-printable
diff -Naur grubconf-0.5.1/src/grubconf_global.c grubconf-0.5.1-mcgrof/src/g=
rubconf_global.c
--- grubconf-0.5.1/src/grubconf_global.c 2003-05-02 16:26:33.000000000 -0400
+++ grubconf-0.5.1-mcgrof/src/grubconf_global.c 2004-03-24 04:11:37.0000000=
00 -0500
@@ -591,7 +591,7 @@
=20
break;
default:
- gtk_message (GTK_MESSAGE_ERROR, _("Invalid command"));
+ gtk_message (GTK_MESSAGE_ERROR, _("[%s line %i] Invalid grub command en=
countered while parsing grub configuration file. Please revise your current=
file syntax or submit bug report to grubconf developers if using latest ve=
rsion."), grubconf_fname, line_num);
return 0;
break;
}
--rJwd6BRFiFCcLxzm--
--jousvV0MzM2p6OtC
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFAYeULat1JN+IKUl4RAvufAJ92MYQzYARy+en1Jz+pNGYm9zJxfQCfWS8R
jpdgLytYuVhbm28E09qb+f8=
=HkcI
-----END PGP SIGNATURE-----
--jousvV0MzM2p6OtC--