Bug#268482: Please include reiser4 fs support

[Vitaly Fertman]

On Tuesday 21 September 2004 07:00, Hans Reiser wrote:
> Robert Millan wrote:
> >Sorry for the late response...
> >
> >On Fri, Aug 27, 2004 at 04:39:39PM -0700, Michael Babcock wrote:
> >>package: grub
> >>version: 0.95+cvs20040624-8
> >>severity: wishlist
> >>
> >>Please include reiser4 fs support in grub.
> >>Path is at
> >>
> >>ftp://ftp.namesys.com/pub/reiser4progs/grub/
> >
> >I have a few questions:
> >
> >  - According to fsys_reiser4.c, Hans Reiser has the copyright on this
> > patch. Hans, did you assign copyright to the FSF in order to merge it
> > upstream?
>
> No, I did not. Actually, I have not even read the patch.;-) Someone send
> me a copy please.
>
> >  - Older reiserfs is identified as "reiserfs" whereas the new one if
> >    "reiser4".  Any particular reason for the inconsistency?
>
> Users said they knew it was an FS. Probably we should change reiserfs to
> reiser3, and keep reiserfs working for backward compatibility only. Hmmm.
>
> >  - The patch modifies stage2/ufs2.h, which has nothing to do with
> > reiserfs. Your changes to ufs2.h look like portability improvements.  Is
> > that it?

yes, there were some problems with compiling. Grub with reiser4 support
links to libreiser4 and libaal, to make it successfully compiled --nostdinc 
option was eliminated and then ufs2 code started producing redefinition 
errors. So I embraced such defines with ifndefs. 
Would you prefere to solve it in another way?

-- 
Thanks,
Vitaly Fertman