Bug#290098: marked as done (grub: doesn't work with cciss and others)

Debian Bug Tracking System owner@bugs.debian.org
Sun, 16 Jan 2005 15:18:09 -0800


Your message dated Sun, 16 Jan 2005 18:02:06 -0500
with message-id <E1CqJPK-000111-00@newraff.debian.org>
and subject line Bug#290098: fixed in grub 0.95+cvs20040624-13
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 12 Jan 2005 19:14:48 +0000
>From agx@sigxcpu.org Wed Jan 12 11:14:48 2005
Return-path: <agx@sigxcpu.org>
Received: from honk1.physik.uni-konstanz.de [134.34.140.224] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Conx9-0003w6-00; Wed, 12 Jan 2005 11:14:48 -0800
Received: from localhost (localhost.localnet [127.0.0.1])
	by honk1.physik.uni-konstanz.de (Postfix) with ESMTP id 3C42B2BC41
	for <submit@bugs.debian.org>; Wed, 12 Jan 2005 20:14:46 +0100 (CET)
Received: from honk1.physik.uni-konstanz.de ([127.0.0.1])
	by localhost (honk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
	id 07119-26 for <submit@bugs.debian.org>;
	Wed, 12 Jan 2005 20:14:15 +0100 (CET)
Received: from bogon.sigxcpu.org (unknown [139.12.2.100])
	(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
	(No client certificate requested)
	by honk1.physik.uni-konstanz.de (Postfix) with ESMTP id C16DD2BC42
	for <submit@bugs.debian.org>; Wed, 12 Jan 2005 20:14:14 +0100 (CET)
Received: by bogon.sigxcpu.org (Postfix, from userid 1000)
	id 0FA5D431E; Wed, 12 Jan 2005 18:27:33 +0100 (CET)
Date: Wed, 12 Jan 2005 18:27:33 +0100
From: Guido Guenther <agx@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: grub: doesn't work with cciss and others
Message-ID: <20050112172733.GA17775@bogon.ms20.nix>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="Kj7319i9nmIyA2yE"
Content-Disposition: inline
X-Reportbug-Version: 3.5
User-Agent: Mutt/1.5.6i
X-Virus-Scanned: by amavisd-new-20030616-p7 (Debian) at honk.physik.uni-konstanz.de
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 


--Kj7319i9nmIyA2yE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Package: grub
Severity: important
Version: 0.95+cvs20040624-12

Hi,
many devices (cciss, ida) name partitions like
<disk>p<part_number> instead of <disk><part_number> (note the extra p).
Grub then fails when calling e.g. 'setup (hd0)'.  This patch fixes the
problem for cciss, ataraid, ida and others. 
Taken from fedora core 3.
Cheers,
 -- Guido

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: powerpc (ppc)
Kernel: Linux 2.6.10-agx0
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)

--Kj7319i9nmIyA2yE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="grub-special_device_names.diff"

--- tmp/grub-0.95+cvs20040624/lib/device.c	2004-05-23 18:45:35.000000000 +0200
+++ grub-0.95+cvs20040624/lib/device.c	2005-01-12 18:19:14.000000000 +0100
@@ -858,8 +938,14 @@
       if (strcmp (dev + strlen(dev) - 5, "/disc") == 0)
 	strcpy (dev + strlen(dev) - 5, "/part");
     }
-  sprintf (dev + strlen(dev), "%d", ((partition >> 16) & 0xFF) + 1);
-  
+  sprintf (dev + strlen(dev), "%s%d", 
+   /* Compaq smart and others */
+   (strncmp(dev, "/dev/ida/", 9) == 0 ||
+   strncmp(dev, "/dev/ataraid/", 13) == 0 ||
+   strncmp(dev, "/dev/cciss/", 11) == 0 ||
+   strncmp(dev, "/dev/rd/", 8) == 0) ? "p" : "",
+   ((partition >> 16) & 0xFF) + 1);
+
   /* Open the partition.  */
   fd = open (dev, O_RDWR);
   if (fd < 0)

--Kj7319i9nmIyA2yE--

---------------------------------------
Received: (at 290098-close) by bugs.debian.org; 16 Jan 2005 23:05:56 +0000
>From katie@ftp-master.debian.org Sun Jan 16 15:05:56 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CqJT1-0001wu-00; Sun, 16 Jan 2005 15:05:56 -0800
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1CqJPK-000111-00; Sun, 16 Jan 2005 18:02:06 -0500
From: Jason Thomas <jason@debian.org>
To: 290098-close@bugs.debian.org
X-Katie: $Revision: 1.55 $
Subject: Bug#290098: fixed in grub 0.95+cvs20040624-13
Message-Id: <E1CqJPK-000111-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sun, 16 Jan 2005 18:02:06 -0500
Delivered-To: 290098-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Source: grub
Source-Version: 0.95+cvs20040624-13

We believe that the bug you reported is fixed in the latest version of
grub, which is due to be installed in the Debian FTP archive:

grub-disk_0.95+cvs20040624-13_all.deb
  to pool/main/g/grub/grub-disk_0.95+cvs20040624-13_all.deb
grub-doc_0.95+cvs20040624-13_all.deb
  to pool/main/g/grub/grub-doc_0.95+cvs20040624-13_all.deb
grub_0.95+cvs20040624-13.diff.gz
  to pool/main/g/grub/grub_0.95+cvs20040624-13.diff.gz
grub_0.95+cvs20040624-13.dsc
  to pool/main/g/grub/grub_0.95+cvs20040624-13.dsc
grub_0.95+cvs20040624-13_i386.deb
  to pool/main/g/grub/grub_0.95+cvs20040624-13_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 290098@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jason Thomas <jason@debian.org> (supplier of updated grub package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 17 Jan 2005 09:29:18 +1100
Source: grub
Binary: grub-disk grub grub-doc
Architecture: source i386 all
Version: 0.95+cvs20040624-13
Distribution: unstable
Urgency: high
Maintainer: Grub Maintainers <pkg-grub-devel@lists.alioth.debian.org>
Changed-By: Jason Thomas <jason@debian.org>
Description: 
 grub       - GRand Unified Bootloader
 grub-disk  - GRUB bootable disk image
 grub-doc   - Documentation for GRand Unified Bootloader
Closes: 290098
Changes: 
 grub (0.95+cvs20040624-13) unstable; urgency=high
 .
   * patches/grub-special_device_names.diff: add support for special devices.
     (closes: #290098)
Files: 
 7dc567686de95e24163739f7b5ed2fc8 888 admin optional grub_0.95+cvs20040624-13.dsc
 4885da86eae1fad8bac54bfd201a121f 57820 admin optional grub_0.95+cvs20040624-13.diff.gz
 d68d6816f833d91001c6b1b2d85c5dc4 358282 admin optional grub_0.95+cvs20040624-13_i386.deb
 6dedf7c8cd467c927a8dc0a43e441566 227890 admin optional grub-disk_0.95+cvs20040624-13_all.deb
 e0de5d3e65f862f7b338cee86628b78d 259504 doc optional grub-doc_0.95+cvs20040624-13_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFB6u087cYwRJJSiL4RAsfRAKDjAIKJ70S62oeRTqeV1nsEpsa8CgCdFoWq
OMMHbWcfmNwWnt/oQSYIdxs=
=2Uqi
-----END PGP SIGNATURE-----