Bug#337145: bashism in /sbin/update-grub prevents splashimage detection

Antonio Kanouras solist at solistland.dnsalias.org
Wed Nov 2 20:36:03 UTC 2005


Package: grub
Version: 0.95+cvs20040624-19
Severity: normal

Hi,

as you can see:

dias:~# update-grub
Searching for GRUB installation directory ... found: /boot/grub .
Testing for an existing GRUB menu.list file... found:
/boot/grub/menu.lst .
Searching for splash image... [: 718: ==: unexpected operator
[: 718: ==: unexpected operator
none found, skipping...
Found kernel: /boot/vmlinuz-2.6.14-1-686
Found kernel: /boot/vmlinuz-2.6.13-1-686
Found kernel: /boot/vmlinuz-2.6.12-1-686
Found kernel: /boot/memtest86+.bin
Updating /boot/grub/menu.lst ... done

dias:~#

I attached a patch which changes '==' to '='.

Cheers,
Antonio

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (750, 'unstable'), (700, 'testing'), (200, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.13-1-686
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages grub depends on:
ii  libc6                         2.3.5-7    GNU C Library: Shared libraries an
ii  libncurses5                   5.5-1      Shared libraries for terminal hand

grub recommends no packages.

-- no debconf information
-------------- next part --------------
--- update-grub.orig	2005-10-31 22:53:55.000000000 +0200
+++ update-grub	2005-11-02 22:13:37.406087000 +0200
@@ -701,11 +701,11 @@
 echo -n "Searching for splash image... "
 current_splash=`grep '^splashimage=' ${grub_dir}/menu.lst || true`
 splashimage_path="splashimage=${grub_root_device}${grub_dir##${boot_device:+/boot}}/splash.xpm.gz"
-if [ -f "${grub_dir}/splash.xpm.gz" ]  && [ "$current_splash" == "" ]; then
+if [ -f "${grub_dir}/splash.xpm.gz" ]  && [ "$current_splash" = "" ]; then
        echo "found: /boot/grub/splash.xpm.gz"
        echo "$splashimage_path" >> $buffer
        echo >> $buffer
-elif [ -f "${grub_dir}/splash.xpm.gz" ]  && [ "$current_splash" == "$splashimage_path" ]; then
+elif [ -f "${grub_dir}/splash.xpm.gz" ]  && [ "$current_splash" = "$splashimage_path" ]; then
        echo "found: /boot/grub/splash.xpm.gz"
        echo "$splashimage_path" >> $buffer
        echo >> $buffer


More information about the Pkg-grub-devel mailing list