Bug#288678: marked as done (grub-disk: "grub-floppy" falsely reports "stage1" as missing)

Fri Nov 25 01:33:15 UTC 2005

Your message dated Thu, 24 Nov 2005 23:20:49 -0200
with message-id <87sltl1q1a.fsf at nurf.casa>
and subject line Wasn't a NMU
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 5 Jan 2005 01:59:38 +0000
>From gilles at harfang.homelinux.org Tue Jan 04 17:59:38 2005
Return-path: <gilles at harfang.homelinux.org>
Received: from guri.is.scarlet.be [193.74.71.22] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Cm0SY-0000S3-00; Tue, 04 Jan 2005 17:59:38 -0800
Received: from (u195-95-89-9.adsl.scarlet.be [195.95.89.9]) 
	by guri.is.scarlet.be  with ESMTP id j051xaq30772 
	for <submit at bugs.debian.org>; 
	Wed, 5 Jan 2005 02:59:36 +0100
Received: from eran by localhost with local (Exim 4.34)
	id 1Cm0SS-0001BW-9V; Wed, 05 Jan 2005 02:59:36 +0100
Date: Wed, 5 Jan 2005 02:59:32 +0100
From: Gilles <gilles at harfang.homelinux.org>
To: Debian Bug Tracking System <submit at bugs.debian.org>
Message-ID: <20050105015932.GA4178 at harfang.homelinux.org>
Mime-Version: 1.0
Content-Disposition: inline
X-Reportbug-Version: 2.63
X-Operating-System: Tiny Tux
X-PGP-Key-Fingerprint: 53B9 972E C2E6 B93C BEAD 7092 09E6 AF46 51D0 5641
User-Agent: Mutt/1.5.6+20040907i
Sender: Gilles <gilles at harfang.homelinux.org>
X-SA-Exim-Connect-IP: <locally generated>
X-SA-Exim-Mail-From: gilles at harfang.homelinux.org
Subject: grub-disk: "grub-floppy" falsely reports "stage1" as missing
Content-Type: text/plain; charset=us-ascii
X-SA-Exim-Version: 4.1 (built Tue, 17 Aug 2004 11:06:07 +0200)
X-SA-Exim-Scanned: Yes (on localhost)
Delivered-To: submit at bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 

Package: grub-disk
Version: 0.95+cvs20040624-12
Severity: important

Hello.

The script "grub-floppy", shipped with current "grub-disk" deb package, 
fails in testing the existence of the required files.
This occurs because a variable is assigned a glob file pattern:

  pkglibdir=/lib/grub/*-*
  stage1=$pkglibdir/stage1

that is subsequently used between quotes:

  [ -f "$stage1" ] || abort "Can't find $stage1, aborting"

where the star is _not_ considered as a meta-character; so, indeed
there is no "/lib/grub/*-*/stage1" file but "/lib/grub/i386-pc/stage1"
is right there!

I understand that the intention was for more generality, but even so
the rest of the script wouldn't work anymore. In effect, what is supposed
to happen in:

  $dd if=$stage1 of="$1" bs="512" count="1"

whenever there are more directories (i.e. other than "i386-pc") and so
the "$stage1" variable would presumably contain a list of files...

An older version of the same utility contained

  pkglibdir=/lib/grub/i386-pc

which is why it worked then.

Side note/question/suggestion:  Is there a reason why such scripts
are still written in such bug-prone a language as "sh", while mistakes
like this would be less likely in e.g. Perl (which is required anyways
on Debian)?

Best,
Gilles

-- System Information:
Debian Release: 3.1
  APT prefers testing
  APT policy: (1002, 'testing'), (99, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.7-vs1.9.2-rc10+g3
Locale: LANG=C, LC_CTYPE=C

-- no debconf information

---------------------------------------
Received: (at 288678-done) by bugs.debian.org; 25 Nov 2005 01:20:50 +0000
>From otavio at debian.org Thu Nov 24 17:20:50 2005
Return-path: <otavio at debian.org>
Received: from aveiro.procergs.com.br ([200.198.128.42])
	by spohr.debian.org with esmtp (Exim 4.50)
	id 1EfSGg-0004bu-26; Thu, 24 Nov 2005 17:20:50 -0800
Received: from localhost (unknown [201.10.58.28])
	by aveiro.procergs.com.br (Postfix) with ESMTP id 0F36E5010B7B;
	Thu, 24 Nov 2005 23:20:30 -0200 (BRDT)
Received: by localhost (Postfix, from userid 1000)
	id 89E191C0B6CB; Thu, 24 Nov 2005 23:20:49 -0200 (BRST)
From: Otavio Salvador <otavio at debian.org>
To: 138318-done at bugs.debian.org,200269-done at bugs.debian.org,266101-done at bugs.debian.org,267224-done at bugs.debian.org,288678-done at bugs.debian.org,298110-done at bugs.debian.org,303967-done at bugs.debian.org,336729-done at bugs.debian.org,336730-done at bugs.debian.org,337145-done at bugs.debian.org,337288-done at bugs.debian.org,338371-done at bugs.debian.org,339687-done at bugs.debian.org,340656-done at bugs.debian.org
Subject: Wasn't a NMU
Organization: O.S. Systems Ltda.
X-URL: http://www.debian.org/~otavio/
X-Attribution: O.S.
Date: Thu, 24 Nov 2005 23:20:49 -0200
Message-ID: <87sltl1q1a.fsf at nurf.casa>
User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-7.0 required=4.0 tests=BAYES_00,HAS_PACKAGE,
	SORTED_RECIPS autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 5

Package: grub
Version: 0.97-1

Hello,

This bug was mark as closed by a NMU by mistake. Closing it according.

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio at debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://www.freedom.ind.br/otavio
---------------------------------------------
"Microsoft gives you Windows ... Linux gives
 you the whole house."