Bug#336573: /sbin/update-grub: fail to find_device because of typo

Progfou jean-christophe.andre at auf.org
Mon Oct 31 09:28:15 UTC 2005


Package: grub
Version: 0.95+cvs20040624-18
Severity: important
Tags: patch


There is a small typo in the new update-grub root discovery
functionality that make grub selecting the wrong root device
in case it's not /dev/hda1 (default)! Here is a patch.

Regards.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (900, 'unstable'), (800, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.13-1-686
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)

Versions of packages grub depends on:
ii  libc6                         2.3.5-7    GNU C Library: Shared libraries an
ii  libncurses5                   5.5-1      Shared libraries for terminal hand

grub recommends no packages.

-- no debconf information
-------------- next part --------------
--- /sbin/update-grub	2005-10-29 23:47:22.000000000 +0700
+++ update-grub	2005-10-31 16:22:15.000000000 +0700
@@ -63,7 +63,7 @@
 	device=
 	if [ -f /etc/fstab ] ; then
 		while read DEV MNT FOO; do
-			if [ `echo "$DEV" | grep -q "^#"` ]; then
+			if `echo "$DEV" | grep -q "^#"`; then
 				continue
 			fi
 			if [ "$MNT" = "$mount_point" ]; then
@@ -91,7 +91,7 @@
 	device=$(find_device "/")
 
 	if [ -z "$device" ]; then
-		echo "$PROG: Cannot determine root device.  Assuming /dev/hda1" >&2
+		echo "Cannot determine root device.  Assuming /dev/hda1" >&2
 		echo "This error is probably caused by an invalid /etc/fstab" >&2
 		device=/dev/hda1
 	fi


More information about the Pkg-grub-devel mailing list