Bug#385980: Not a bug?

[Joey Hess]

Kapil Hari Paranjape wrote:
> Removal of the autogenerated files *is* what the "clean" target
> already does. The problem is that upstream source comes with its own
> set of autogenerated files and these get removed/replaced during the
> autoconf run.

That doesn't make any sense. If the files are removed by the clean
target, they will not appear in the diff; this bug report shows them in
the diff.

> I read that and have since then been going through my own packages
> trying to implement it. Since upstream is often not careful enough
> about "distclean", this requirement is sometimes rather hard to
> implement.

To the contrary, it's trivial, you just remove them in the clean rule.

dbs is a complete red herring in this discussion.

Here's a patch to grub that fixes this bug:

diff -ur old/grub-0.97/debian/rules grub-0.97/debian/rules
--- old/grub-0.97/debian/rules	2006-09-21 22:36:30.000000000 -0400
+++ grub-0.97/debian/rules	2006-09-21 22:36:17.000000000 -0400
@@ -181,7 +181,7 @@
 	-( cd docs && rm -rf grub multiboot )
 
 	# remove files that will be change due our automake and autoconf rebuilding
-	-rm -f $(find . -name 'Makefile.in' -o \
+	-rm -f $(shell find . -name 'Makefile.in' -o \
                     -name 'aclocal.m4' -o \
                     -name 'configure')
 
-- 
see shy jo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20060921/2ce64bee/attachment.pgp