Bug#345931: If the problem is that the user doesn't know ...

[Kapil Hari Paranjape]

On Mon, 25 Sep 2006, Otavio Salvador wrote:
> Kapil Hari Paranjape <kapil at imsc.res.in> writes:
> 
> > Considering the idea of a "feature freeze" for "grub" and a move to
> > try and consolidate "grub2" instead, I think this solution is simpler
> > to use than Solution 1 and 2.
> 
> I tend to agree with you.
> 
> Besides it keep clear that grub shell shouldn't be use if you doesn't
> know what you're doing.
> 
> Do you think the current patch is ready for "wide use"?

Its my patch so I'm bound to like it :)

More objectively:

1. It only introduces some printf's so it does not seem to be
   something that can cause a build or security problem.

2. You may want to pass the actual warning messages by some
   of the other developers/bug reporters. You also need to 
   check with them that this is a good enough fix.

3. I checked that this message *does not* appear when one uses
   the scripts. So the message will not come up to confuse the
   common user.

Overall, modulo (2) it looks as if the patch does fix things.

I also feel that implementing the version check is a bit complex since:

(a) the builtin.c has to know the actual location of the version
    string in the binary.

(b) builtin.c would need to be able to read ELF information to
    actually find this string.

(c) I have never actually implemented such a version check or know
    of some source where such a check is implemented.

Point (c) is of course the most important one :)

Thanks and regards,

Kapil.
--
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20060926/e8575eba/attachment.pgp