Bug#423648: grub-pc: md/lvm path check in getroot.c breaks booting

[Sam Morris]

Package: grub-pc
Version: 1.95+20070507-1
Severity: normal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

While debugging #423022 I found the following:

> I had to do one more thing to boot up correctly: edit the command line.
> It had 'root=md0' but it needed 'root=/dev/md0'. It appears that
> 'grub-probe -t device /boot/grub' outputs 'md0' when it should be
> outputting '/dev/md0' (just as it outputs e.g., '/dev/hde1' instead of
> 'hde1' for 'grub-probe -t device /mnt'). Shall I file a separate bug for
> that?

This is caused by the code within the #ifdef __linux__ in
'util/i386/pc/getroot.c'. I can't see what the point of this code
is--the kernel will always want 'root=/dev/md0' or
'root=/dev/mapper/foo-bar' and not the truncated form.

(In fact /dev/foo/bar is better than /dev/mapper/foo-bar... the former is
the proper LVM device interface, the latter is just an implementation
detail (LVM did not always used to use device-mapper). However loads of
other tools use /dev/mapper/foo-bar directly so this is just a minor
aesthetic problem).

- -- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (530, 'testing'), (520, 'unstable'), (510, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.18-4-k7 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages grub-pc depends on:
ii  libc6                         2.5-7      GNU C Library: Shared libraries
ii  liblzo1                       1.08-3     data compression library (old vers

grub-pc recommends no packages.

- -- no debconf information

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFGR0nDshl/216gEHgRAnDxAKDbE6VD58CAO5cMjSi0NYN01vLlHQCfY10q
AWb2AWWHDhQfuNg/VxYg2yw=
=ecRA
-----END PGP SIGNATURE-----