Bug#476517: grub-pc: improper handling of GRUB_PRELOAD_MODULES in update-grub

[Stephane Chazelas]

Package: grub-pc
Version: 1.96+20080413-1
Severity: important


Hiya,

one gets an error if he defines GRUB_PRELOAD_MODULES in
/etc/default/grub.

This is because of the typo in update-grub that can be fixed
with:

--- /tmp/update-grub	2008-04-17 10:10:49.000000000 +0100
+++ /usr/sbin/update-grub	2008-04-17 10:13:29.000000000 +0100
@@ -136,7 +136,7 @@
   gfxterm)
     if path=`font_path` ; then
       GRUB_FONT_PATH="`convert_system_path_to_grub_path ${path}`"
-      GRUB_PRELOAD_MODULES="`${GRUB_PRELOAD_MODULES} ${grub_probe} -t abstraction ${path}`"
+      GRUB_PRELOAD_MODULES="${GRUB_PRELOAD_MODULES} `${grub_probe} -t abstraction ${path}`"
     else
       # fallback to console
       GRUB_TERMINAL=console


(notice the misplaced backtick).

Cheers,
Stephane

-- Package-specific info:

*********************** BEGIN /proc/mounts
/dev/mapper/vol-debian / ext3 rw,errors=remount-ro,data=ordered 0 0
/dev/mapper/vol-debian /dev/.static/dev ext3 rw,errors=remount-ro,data=ordered 0 0
/dev/mapper/vol-fast /unsafe ext3 rw,errors=remount-ro,data=ordered 0 0
*********************** END /proc/mounts

*********************** BEGIN /boot/grub/device.map
(hd0)	/dev/sda
(hd1)	/dev/sdb
*********************** END /boot/grub/device.map

*********************** BEGIN /boot/grub/grub.cfg
#
# DO NOT EDIT THIS FILE
#
# It is automatically generated by /usr/sbin/update-grub using templates
# from /etc/grub.d and settings from /etc/default/grub
#

### BEGIN /etc/grub.d/000_raid ###
insmod raid
### END /etc/grub.d/000_raid ###

### BEGIN /etc/grub.d/00_header ###
insmod lvm
set default=0
set timeout=5
set root=(vol-debian)
if font (vol-debian)/usr/share/grub/unicode.pff ; then
  set gfxmode=640x480
  insmod gfxterm
  insmod vbe
  terminal gfxterm
fi
### END /etc/grub.d/00_header ###

### BEGIN /etc/grub.d/05_debian_theme ###
insmod png
if background_image (vol-debian)/usr/share/images/desktop-base/debian-blueish-wallpaper-640x480.png ; then
  set color_normal=black/black
  set color_highlight=magenta/black
else
  set menu_color_normal=cyan/blue
  set menu_color_highlight=white/blue
fi
### END /etc/grub.d/05_debian_theme ###

### BEGIN /etc/grub.d/10_hurd ###
### END /etc/grub.d/10_hurd ###

### BEGIN /etc/grub.d/10_linux ###
menuentry "Debian GNU/Linux, linux 2.6.25-rc9" {
	linux	(vol-debian)/boot/vmlinuz-2.6.25-rc9 root=/dev/mapper/vol-debian ro apic
	initrd	(vol-debian)/boot/initrd.img-2.6.25-rc9
}
menuentry "Debian GNU/Linux, linux 2.6.25-rc9 (single-user mode)" {
	linux	(vol-debian)/boot/vmlinuz-2.6.25-rc9 root=/dev/mapper/vol-debian ro single apic
	initrd	(vol-debian)/boot/initrd.img-2.6.25-rc9
}
### END /etc/grub.d/10_linux ###

### BEGIN /etc/grub.d/30_os-prober ###
### END /etc/grub.d/30_os-prober ###
*********************** END /boot/grub/grub.cfg

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.25-rc9
Locale: LANG=en_GB.ISO-8859-15, LC_CTYPE=en_GB.ISO-8859-15 (charmap=ISO-8859-15)
Shell: /bin/sh linked to /bin/bash

Versions of packages grub-pc depends on:
ii  debconf [debconf-2.0]    1.5.20          Debian configuration management sy
ii  grub-common              1.96+20080413-1 GRand Unified Bootloader, version 
ii  libc6                    2.7-10          GNU C Library: Shared libraries
ii  liblzo1                  1.08-3          data compression library (old vers
ii  libncurses5              5.6+20080405-1  Shared libraries for terminal hand

Versions of packages grub-pc recommends:
ii  os-prober                     1.24       utility to detect other OSes on a 

-- debconf-show failed