Bug#495282: grub-pc: desktop-grub usage instead of hardcoding background file name

[Felix Zielcke]

Hello,

Am Freitag, den 15.08.2008, 23:37 +0200 schrieb Fathi Boudra:
> Hi robert,

I'm not Robert but I hope that I'm allowed to reply too, as a
Co-Maintainer :)

I hadn't yet a chance to talk with him about it.

> could you use desktop-grub symlink (provided by desktop-base package and 
> alternative system) instead of hardcoding background file name.

Great idea to make this a symlink.
We got even recently a request to make this a variable (#493106), but
that would be too complex.

Do you plan to get this into lenny?


--- a/debian/grub-pc.postinst
+++ b/debian/grub-pc.postinst
-    for i in /usr/share/grub/ascii.pff /usr/share/images/desktop-base/debian-blueish-wallpaper-640x480.png ; do
+    for i in /usr/share/grub/ascii.pff /usr/share/images/desktop-base/debian-grub ; do

--- a/debian/grub.d/05_debian_theme
+++ b/debian/grub.d/05_debian_theme
-  for i in {/boot/grub,/usr/share/images/desktop-base}/debian-blueish-wallpaper-640x480.{png,tga} ; do
+  for i in {/boot/grub,/usr/share/images/desktop-base}/desktop-grub ; do

I looked at your SVN changes and I assume this should be both
desktop-grub or am I wrong?

I wonder if it's a good idea to fallback to the old file if the symlink
doestn't exist to make the transition easier.