Bug#464464: grub-pc: syntax error in generated grub.cfg

[Barry Schatz]

Package: grub-pc
Version: 1.96+20080203-1
Severity: critical
Justification: breaks the whole system

The If-statement 00_header writes to grub.cfg is malformed, and causes grub2 
to get stuck in an infinite loop of syntax errors.

This code breaks the system:

  if font (hd0,5)/usr/share/grub/unicode.pff ; then
    set gfxmode=1024x768
    insmod gfxterm
    insmod vbe
    terminal gfxterm
  fi

My fixed grub.cfg is below. I fixed 00_header the same way:

  font (hd0,5)/usr/share/grub/unicode.pff
  set gfxmode=1024x768
  insmod gfxterm
  insmod vbe
  terminal gfxterm


-- Package-specific info:

*********************** BEGIN /proc/mounts
rootfs / rootfs rw 0 0
none /sys sysfs rw,nosuid,nodev,noexec 0 0
none /proc proc rw,nosuid,nodev,noexec 0 0
udev /dev tmpfs rw 0 0
/dev/sda5 / ext3 rw,data=ordered 0 0
/dev/sda5 /dev/.static/dev ext3 rw,data=ordered 0 0
tmpfs /lib/init/rw tmpfs rw,nosuid 0 0
usbfs /proc/bus/usb usbfs rw,nosuid,nodev,noexec 0 0
tmpfs /dev/shm tmpfs rw,nosuid,nodev 0 0
devpts /dev/pts devpts rw,nosuid,noexec 0 0
fusectl /sys/fs/fuse/connections fusectl rw 0 0
/dev/sda6 /home reiserfs rw 0 0
/dev/sda2 /mnt/c fuseblk 
rw,nosuid,nodev,noexec,user_id=0,group_id=0,default_permissions,allow_other 0 
0
binfmt_misc /proc/sys/fs/binfmt_misc binfmt_misc rw,nosuid,nodev,noexec 0 0
*********************** END /proc/mounts

*********************** BEGIN /boot/grub/device.map
(hd0)	/dev/sda
*********************** END /boot/grub/device.map

*********************** BEGIN /boot/grub/grub.cfg
#
# DO NOT EDIT THIS FILE
#
# It is automatically generated by /usr/sbin/update-grub using templates
# from /etc/grub.d and settings from /etc/default/grub
#

### BEGIN /etc/grub.d/00_header ###
set default=0
set timeout=5
set root=(hd0,5)
#bug: syntax error right here:
font (hd0,5)/usr/share/grub/unicode.pff
set gfxmode=1024x768
insmod gfxterm
insmod vbe
terminal gfxterm

### END /etc/grub.d/00_header ###

### BEGIN /etc/grub.d/05_debian_theme ###
set menu_color_normal=cyan/blue
set menu_color_highlight=white/blue
### END /etc/grub.d/05_debian_theme ###

### BEGIN /etc/grub.d/10_hurd ###
### END /etc/grub.d/10_hurd ###

### BEGIN /etc/grub.d/10_linux ###
menuentry "Debian GNU/Linux, linux 2.6.22-3-686" {
	linux	(hd0,5)/boot/vmlinuz-2.6.22-3-686 root=/dev/sda5 ro 
	initrd	(hd0,5)/boot/initrd.img-2.6.22-3-686
}
menuentry "Debian GNU/Linux, linux 2.6.22-3-686 (single-user mode)" {
	linux	(hd0,5)/boot/vmlinuz-2.6.22-3-686 root=/dev/sda5 ro single 
	initrd	(hd0,5)/boot/initrd.img-2.6.22-3-686
}
### END /etc/grub.d/10_linux ###

### BEGIN /etc/grub.d/20_memtest86+ ###
menuentry "Memory test (memtest86+)" {
	linux	(hd0,5)/boot/memtest86+.bin
}
### END /etc/grub.d/20_memtest86+ ###

### BEGIN /etc/grub.d/21_dell ###
menuentry "Dell Diagnostic Utilities" {
  set root=(hd0,1)
  chainloader +1
}
### END /etc/grub.d/21_dell ###

### BEGIN /etc/grub.d/21_windows ###
menuentry "Microsoft Windows XP" {
  set root=(hd0,2)
  chainloader +1
}
### END /etc/grub.d/21_windows ###
*********************** END /boot/grub/grub.cfg

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (990, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.22-3-686 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages grub-pc depends on:
ii  base-files                4.0.2          Debian base system miscellaneous 
f
ii  debconf [debconf-2.0]     1.5.18         Debian configuration management 
sy
ii  libc6                     2.7-6          GNU C Library: Shared libraries
ii  liblzo2-2                 2.02-3         data compression library
ii  libncurses5               5.6+20080119-1 Shared libraries for terminal 
hand

grub-pc recommends no packages.

-- debconf information:
* grub-pc/chainload_from_menu.lst: true
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20080206/f5fe0321/attachment.pgp