Bug#489679: grub2: New version comparesion patch breaks update-grub

[Kanru Chen]

Package: grub2
Version: 1.96+20080704-1
Severity: grave
Justification: renders package unusable


02_old_linux_version_comparison.diff introduced CompareVersions() but
checks it's result in an incorrect way.

--- 02_old_linux_version_comparison.diff.old    2008-07-07 12:32:01.631741821 +0800
+++ 02_old_linux_version_comparison.diff    2008-07-07 12:32:10.497741060 +0800
@@ -101,7 +101,7 @@
 -    *:*.old) b=`echo -n $b | sed -e s/\.old$//g` ; cmp=ge ;;
 -  esac
 -  test_numeric $a $cmp $b
-+  [ `CompareVersions "$a" "$b"` == 1 ]
++  [ `CompareVersions "$a" "$b"` -eq 1 ]
    return $?
  }


-- Package-specific info:

*********************** BEGIN /proc/mounts
/dev/sda3 / xfs rw,nodiratime,relatime,noquota 0 0
/dev/sda3 /dev/.static/dev xfs ro,noquota 0 0
/dev/sda2 /boot ext2 rw,nodiratime,relatime,errors=continue 0 0
*********************** END /proc/mounts

*********************** BEGIN /boot/grub/device.map
(hd0)	/dev/sda
(hd1)	/dev/sdb
*********************** END /boot/grub/device.map

*********************** BEGIN /boot/grub/grub.cfg
#
# DO NOT EDIT THIS FILE
#
# It is automatically generated by /usr/sbin/update-grub using templates
# from /etc/grub.d and settings from /etc/default/grub
#

### BEGIN /etc/grub.d/00_header ###
set default=0
set timeout=5
set root=(hd0,2)
search --fs-uuid --set a7a08697-4d66-421d-b2d6-d0fb0f3e1e66
if font /grub/unicode.pff ; then
  set gfxmode=640x480
  insmod gfxterm
  insmod vbe
  terminal gfxterm
fi
### END /etc/grub.d/00_header ###

### BEGIN /etc/grub.d/05_debian_theme ###
set root=(hd0,2)
search --fs-uuid --set a7a08697-4d66-421d-b2d6-d0fb0f3e1e66
insmod png
if background_image /grub/debian-blueish-wallpaper-640x480.png ; then
  set color_normal=black/black
  set color_highlight=magenta/black
else
  set menu_color_normal=cyan/blue
  set menu_color_highlight=white/blue
fi
### END /etc/grub.d/05_debian_theme ###

### BEGIN /etc/grub.d/10_hurd ###
### END /etc/grub.d/10_hurd ###

### BEGIN /etc/grub.d/10_linux ###
set root=(hd0,2)
search --fs-uuid --set a7a08697-4d66-421d-b2d6-d0fb0f3e1e66
menuentry "Debian GNU/Linux, linux 2.6.26-rc8" {
	linux	/vmlinuz-2.6.26-rc8 root=/dev/sda3 ro  
	initrd	/initrd.img-2.6.26-rc8
}
menuentry "Debian GNU/Linux, linux 2.6.26-rc8 (single-user mode)" {
	linux	/vmlinuz-2.6.26-rc8 root=/dev/sda3 ro single 
	initrd	/initrd.img-2.6.26-rc8
}
menuentry "Debian GNU/Linux, linux 2.6.26-rc6" {
	linux	/vmlinuz-2.6.26-rc6 root=/dev/sda3 ro  
	initrd	/initrd.img-2.6.26-rc6
}
menuentry "Debian GNU/Linux, linux 2.6.26-rc6 (single-user mode)" {
	linux	/vmlinuz-2.6.26-rc6 root=/dev/sda3 ro single 
	initrd	/initrd.img-2.6.26-rc6
}
menuentry "Debian GNU/Linux, linux 2.6.26-rc4" {
	linux	/vmlinuz-2.6.26-rc4 root=/dev/sda3 ro  
	initrd	/initrd.img-2.6.26-rc4
}
menuentry "Debian GNU/Linux, linux 2.6.26-rc4 (single-user mode)" {
	linux	/vmlinuz-2.6.26-rc4 root=/dev/sda3 ro single 
	initrd	/initrd.img-2.6.26-rc4
}
menuentry "Debian GNU/Linux, linux 2.6.26-rc2" {
	linux	/vmlinuz-2.6.26-rc2 root=/dev/sda3 ro  
	initrd	/initrd.img-2.6.26-rc2
}
menuentry "Debian GNU/Linux, linux 2.6.26-rc2 (single-user mode)" {
	linux	/vmlinuz-2.6.26-rc2 root=/dev/sda3 ro single 
	initrd	/initrd.img-2.6.26-rc2
}
menuentry "Debian GNU/Linux, linux 2.6.26-rc1" {
	linux	/vmlinuz-2.6.26-rc1 root=/dev/sda3 ro  
	initrd	/initrd.img-2.6.26-rc1
}
menuentry "Debian GNU/Linux, linux 2.6.26-rc1 (single-user mode)" {
	linux	/vmlinuz-2.6.26-rc1 root=/dev/sda3 ro single 
	initrd	/initrd.img-2.6.26-rc1
}
menuentry "Debian GNU/Linux, linux 2.6.25-rc9" {
	linux	/vmlinuz-2.6.25-rc9 root=/dev/sda3 ro  
	initrd	/initrd.img-2.6.25-rc9
}
menuentry "Debian GNU/Linux, linux 2.6.25-rc9 (single-user mode)" {
	linux	/vmlinuz-2.6.25-rc9 root=/dev/sda3 ro single 
	initrd	/initrd.img-2.6.25-rc9
}
menuentry "Debian GNU/Linux, linux 2.6.25-rc5" {
	linux	/vmlinuz-2.6.25-rc5 root=/dev/sda3 ro  
	initrd	/initrd.img-2.6.25-rc5
}
menuentry "Debian GNU/Linux, linux 2.6.25-rc5 (single-user mode)" {
	linux	/vmlinuz-2.6.25-rc5 root=/dev/sda3 ro single 
	initrd	/initrd.img-2.6.25-rc5
}
### END /etc/grub.d/10_linux ###

### BEGIN /etc/grub.d/30_os-prober ###
### END /etc/grub.d/30_os-prober ###
*********************** END /boot/grub/grub.cfg

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-rc8 (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages grub2 depends on:
ii  debconf                  1.5.22          Debian configuration management sy
ii  grub-pc                  1.96+20080704-1 GRand Unified Bootloader, version 

grub2 recommends no packages.

-- debconf information:
  grub2/numbering_scheme_transition: