Bug#504444: grub: broken detection of supported Xen hypervisor versions

[Stephen Gran]

This one time, at band camp, Robert Millan said:
> On Mon, Nov 03, 2008 at 11:05:38PM +0000, Stephen Gran wrote:
> > This one time, at band camp, Stephen Gran said:
> > > The menu.lst below is after making this change:
> > > 
> > > --- /usr/sbin/update-grub       2008-11-03 21:59:20.000000000 +0000
> > > +++ update-grub 2008-11-03 21:59:41.000000000 +0000
> > > @@ -919,7 +919,7 @@
> > > 
> > >         found=
> > >         for hypervisorVersion in $hypervisorVersions; do
> > > -               hypervisor="/boot/xen-$hypervisorVersion.gz"
> > > +               hypervisor="$kernel_dir/xen-$hypervisorVersion.gz"
> > >                 if [ -e "$hypervisor" ]; then
> > >                         found=1
> > > 
> > 
> > Er, that's obviously backwards, sorry about that :)
> 
> I'm confused.  You mean your change broke something, or that it fixes the
> problem you describe?

Sorry, I thought it was clear enough.  Without my change, the test for
the existence of the hypervisor binary always failed, and I was
presented with a menu.lst that contained tons of unbootable entries.
With my change, I got the right behavior.  However, the patch I sent was
backwards - the diff is between $new $old, instead of $old $new, as it
should have been.

Cheers,
-- 
 -----------------------------------------------------------------
|   ,''`.                                            Stephen Gran |
|  : :' :                                        sgran at debian.org |
|  `. `'                        Debian user, admin, and developer |
|    `-                                     http://www.debian.org |
 -----------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-grub-devel/attachments/20081107/df49fdad/attachment.pgp