Bug#562036: grub-pc: Add support for GFXPAYLOAD same as for GFXMODE

[Felix Zielcke]

Am Dienstag, den 22.12.2009, 01:12 -0500 schrieb Jan Muszynski:
> Package: grub-pc
> Version: 1.98~20091210-1
> Severity: normal
> Tags: patch
> 
> Currently console resolution defaults to 640x480, even if GFXMODE is
> set.
> Changing this requires modifying the scripts in /etc/grub.d, which is
> not
> very user friendly and also makes it a pain when the scripts are
> changed due
> to updates.
> 
> Instead I would propose to add support for GFXPAYLOAD in
> /etc/default/grub.
> Attached patch should do the job.

We have already a bug report for this.
See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=536453 with which I
just merged yours.
But the one who made first a patch for this and sent this upstream
disappeared.
So feel free to go ahead and talk with upstream.

> You'll notice I switched the -e from
> the
> shebang line to an explicit set -e For why see:
>  http://blog.andrew.net.au/2009/11/20#dash_e_shebang_bad

Sounds wise, but I suggest you discuss this with upstream.
It would probable help if you're willing to change it in every script
file we have for consistency.

> Need anything further, just holler. I'll have a few more bug reports
> (some with patches)
> coming up in the near future. I'll wait for the version currently in
> incoming first.
> (For starters the custom menu entry listed below is ignored, but I
> need to look at things closer first)

Note that we require you to be willing to send your patches directly to
upstream due to GNU/FSF policies and we don't want to diverge much from
upstream like we did with GRUB Legacy. Supporting much things on our own
which are clearly a benefit for upstream too is jus a PITA.

>  
>  -jcm

GRUB_GFXPAYLOAD=keep is by the way already default in 05_debian_theme of
the experimental uploads. But that file is of course Debian specific.

-- 
Felix Zielcke
Proud Debian Maintainer and GNU GRUB developer